Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join schedules to timeseries #465

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Join schedules to timeseries #465

merged 8 commits into from
Nov 12, 2024

Conversation

rajeee
Copy link
Contributor

@rajeee rajeee commented Aug 14, 2024

Fixes # .

Pull Request Description

We used to concatenate the schedules to timeseries before - it stopped working after ResStock changed the naming on the schedule files. This PR re-introduces it.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/coverage.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Kestrel/Eagle to make sure it all works if you made changes that will affect Kestrel/Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@rajeee rajeee marked this pull request as ready for review November 6, 2024 20:19
@rajeee rajeee requested a review from nmerket November 11, 2024 16:05
if re.match(r".*schedules.*\.csv", file):
schedules_filepath = os.path.join(sim_dir, "generated_files", file)
schedules_filepaths = []
for file in os.listdir(output_dir):
Copy link
Collaborator

@wenyikuang wenyikuang Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the path in sim_dir/generated_files/.*schedules.*.csv to sim_dir/run/in.schedules.*\.csv, have or do we need changed the place to export them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@wenyikuang wenyikuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just want to know how does the run/in.schedules.*\.csv files save? Do we need modify the logic which generated the generated_files/.*schedules.*.csv ?

@rajeee rajeee merged commit be16f2e into develop Nov 12, 2024
4 checks passed
@joseph-robertson joseph-robertson mentioned this pull request Nov 13, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants