-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join schedules to timeseries #465
Conversation
if re.match(r".*schedules.*\.csv", file): | ||
schedules_filepath = os.path.join(sim_dir, "generated_files", file) | ||
schedules_filepaths = [] | ||
for file in os.listdir(output_dir): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From reading the path in sim_dir/generated_files/.*schedules.*.csv
to sim_dir/run/in.schedules.*\.csv
, have or do we need changed the place to export them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the path ResStock export the schedules in.
https://github.com/NREL/resstock/blob/17360a717583ab456812016625cc4357be9bd236/resources/hpxml-measures/HPXMLtoOpenStudio/measure.rb#L281
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just want to know how does the run/in.schedules.*\.csv
files save? Do we need modify the logic which generated the generated_files/.*schedules.*.csv
?
Fixes # .
Pull Request Description
We used to concatenate the schedules to timeseries before - it stopped working after ResStock changed the naming on the schedule files. This PR re-introduces it.
Checklist
Not all may apply
minimum_coverage
in.github/workflows/coverage.yml
as necessary.