Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LOCAL_SCRATCH from /tmp/scratch/$USER to /tmp/scratch/$JOBID #449

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

yingli-NREL
Copy link

Due to the change in the node local scratch configuration, to write to local disk, we now need to use the $TMPDIR variable. https://nrel.github.io/HPC/Documentation/Systems/Kestrel/kestrel_release_notes/

@yingli-NREL yingli-NREL requested a review from rajeee April 19, 2024 20:56
Copy link

github-actions bot commented Apr 19, 2024

File Coverage
All files 87%
base.py 91%
exc.py 57%
hpc.py 78%
local.py 70%
postprocessing.py 84%
utils.py 92%
cloud/docker_base.py 88%
sampler/base.py 78%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_local.py 97%
test/test_validation.py 97%
workflow_generator/base.py 89%
workflow_generator/commercial.py 52%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against a3a27b0

@@ -15,7 +15,7 @@ source "$MY_PYTHON_ENV/bin/activate"
# Default LOCAL_SCRATCH = /tmp/scratch
# Setting to user-specific dir to avoid
# issues with deleting previous buildstock run debris
export LOCAL_SCRATCH=/tmp/scratch/$USER
export LOCAL_SCRATCH=/tmp/scratch/$SLURM_JOB_ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use $TMPDIR variable as suggested:
export LOCAL_SCRATCH=$TMPDIR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to export LOCAL_SCRATCH=$TMPDIR

Copy link
Contributor

@rajeee rajeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajeee rajeee merged commit bcb331a into develop Jul 22, 2024
4 of 5 checks passed
@rajeee rajeee deleted the write_to_local_disk_kestrel_change branch July 22, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants