Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer downloading singularity image automatically #386

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Aug 9, 2023

Fixes #256.

Pull Request Description

Instead of fixing the collision I'm just removing the "feature" that would download the singularity image to the run directory. It's better to know and make sure it's in the shared directory in the first place.

Checklist

Not all may apply

  • Code changes (must work)
  • Tests exercising your feature/bug fix (check coverage report on Checks -> BuildStockBatch Tests -> Artifacts)
  • Coverage has increased or at least not decreased. Update minimum_coverage in .github/workflows/ci.yml as necessary.
  • All other unit and integration tests passing
  • Update validation for project config yaml file changes
  • Update existing documentation
  • Run a small batch run on Eagle to make sure it all works if you made changes that will affect Eagle
  • Add to the changelog_dev.rst file and propose migration text in the pull request

@nmerket nmerket changed the title removing download of singularity image Removing download of singularity image Aug 9, 2023
@nmerket nmerket changed the title Removing download of singularity image No longer downloading singularity image automatically Aug 9, 2023
@github-actions
Copy link

File Coverage
All files 84%
base.py 89%
eagle.py 79%
exc.py 57%
local.py 50%
postprocessing.py 84%
utils.py 96%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 83%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against f104012

@nmerket nmerket merged commit 0438864 into develop Aug 21, 2023
6 checks passed
@nmerket nmerket deleted the singularity_image_collision branch August 21, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singularity image collision on download
1 participant