Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silvana issues fixing #545

Merged
merged 6 commits into from
Sep 23, 2024
Merged

Silvana issues fixing #545

merged 6 commits into from
Sep 23, 2024

Commits on Aug 21, 2024

  1. removing idle comments

    @shirubana
    shirubana committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    696a7e6 View commit details
    Browse the repository at this point in the history

  2. glass edge #513 

    adds glass edge as an input to function

(and some documentation linting)
    @shirubana
    shirubana committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    5287eb9 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Merge remote-tracking branch 'remotes/NREL/main' into silvana-issues-… 

    …fixing
    @cdeline
    cdeline committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d8c4452 View commit details
    Browse the repository at this point in the history

  2. New pytests for desired makeModule behavior (1mm absorber and z = gla… 

    …ss thickness)
    @cdeline
    cdeline committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    d66cd4b View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Update glass creation logic - now it's working as intended.

    @cdeline
    cdeline committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    711323b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. more pytests

    @cdeline
    cdeline committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c502f19 View commit details
    Browse the repository at this point in the history