Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

512 cec performance #543

Merged
merged 21 commits into from
Sep 18, 2024
Merged

512 cec performance #543

merged 21 commits into from
Sep 18, 2024

Conversation

cdeline
Copy link
Contributor

@cdeline cdeline commented Sep 3, 2024

Push CeC single diode data and performance functions into the ModuleObj class. This allows for different module types on different scenes.

  • Todo: manualapi.rst and whatsnew updates: analysis.calculatePerformance; performance.calculatePerformanceGencumsky; demo.calculatePerformance1axis; performance.calculatePerformance; module.addCEC; module.calculatePerformance.
  • Rename functions to align with calculatePerformance
  • Make sure performance is running in ModelChain
  • Look into making getResults() a @Property - for RadianceObj it requires a trackerdict at least...
    Check into passing metdata as a MetObj, or just internal AnalysisObj values for AnalysisObj.calculatePerformance?
  • performance.calculatePerformanceGencumsky needs to take a results input with varying sensor size for each entry. pd.DataFrame.from_dict(dict(zip(results.index, results['Wm2Front']))).T requires uniform sensor size per entry

@cdeline
Copy link
Contributor Author

cdeline commented Sep 9, 2024

There's still a bug in here if demo.calculatePerformance1axis() is run twice consecutively... checking it out..
... ok it was related to duplicate columns being returned in AnalysisObj.results. Fixed it. Things are looking good!

@cdeline
Copy link
Contributor Author

cdeline commented Sep 10, 2024

This fixes #512

@cdeline
Copy link
Contributor Author

cdeline commented Sep 11, 2024

@shirubana - this is getting good to go. Please check out Tutorial 21 for usage examples

@cdeline cdeline merged commit f3e5878 into development Sep 18, 2024
12 checks passed
@cdeline
Copy link
Contributor Author

cdeline commented Sep 18, 2024

Merging into development. Let's GOOO!

@cdeline cdeline deleted the 512_CEC_performance branch October 2, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant