Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi scene objs #488

Closed
wants to merge 6 commits into from
Closed

Multi scene objs #488

wants to merge 6 commits into from

Conversation

cdeline
Copy link
Contributor

@cdeline cdeline commented Nov 10, 2023

Updated testing and functionality. Now working:
-running makeScene1axis multiple times adds multiple scenes to the trackerdict.
-running analysis1axis multiple times adds multiple analysis values to Results
-analysis1axis has a new sceneNum input to select which scene you're trying to analyze.
-exporttrackerdict iterates over sceneNum

todo:

  • CompileResult is hardcoded to run once over all sceneNums, even if bifacial modules and details are different.
  • Functionality to pop scenes from trackerdict if desired. This may mess up some naming, for instance if we have Scene0, Scene1, Scene2 and Scene1 gets popped. May require renaming the remaining scenes...
  • RadObj.addPiles needs to be moved out of RadObj and refactored
  • Check appendtoscene function- it's currently both in RadObj and SceneObj, and operates differently in each place...
  • In modelchain, sceneNum is hardwired to 0 in simulationParamsDict.get('saveImage') (line 253 of modelchain)
  • notebooks need to be updated to demo new functionality
  • readthedocs API and whatsnew
  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with GUI
  • New functions added to __init__.py

…ch extracts scene.radfiles from each scene in the list. Tests are passing
…j.appendtoScene.

Update runs of tutorials 7 and 19, which are working.
…l tests are passing, still need modelchain updates..
…bug fixed. tests fixed, new functionality tested in test_1axis_gencumSky
@cdeline cdeline mentioned this pull request Nov 10, 2023
13 tasks
@cdeline
Copy link
Contributor Author

cdeline commented Nov 10, 2023

closed this version, working from #487 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant