Skip to content

Commit

Permalink
revert previous commit. It's not so straightforward to just remove `P…
Browse files Browse the repository at this point in the history
…Vmodule` name from the deepcleanResult search...
  • Loading branch information
cdeline committed Sep 10, 2024
1 parent f150969 commit b3818f6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 11 deletions.
6 changes: 3 additions & 3 deletions bifacial_radiance/load.py
Original file line number Diff line number Diff line change
Expand Up @@ -419,11 +419,11 @@ def filter_sub(resultsDict, sensorsy, frontmask, backmask=None):
# by default, these are the material values attached to bifacial_radiance
# modules
if 'mattype' in resultsDict:
frontmask = ['.6457']
else: frontmask = ['.2310'] # result only has _Back file passed
frontmask = ['PVmodule.6457']
else: frontmask = ['PVmodule.2310'] # result only has _Back file passed

if 'rearMat' in resultsDict:
backmask = ['.2310']
backmask = ['PVmodule.2310']
else: backmask = None

else:
Expand Down
3 changes: 2 additions & 1 deletion docs/sphinx/source/whatsnew/pending.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ Enhancements
Bug fixes
~~~~~~~~~
* versioning with setuptools_scm- set fallback_version to bifirad v0.4.3 to prevent crashes if git is not present (:issue:`535`)(:pull:`539`)
* Updated tutorial8 to use `PVmodule` module name instead of `test-module`. This bypasses a bug in :py:class:`~bifacial_radiance.load.deepcleanResult` that keys off the 'PVmodule' name. (:issue:`445`) (:issue:`509`) (:pull:`547`)

Documentation
~~~~~~~~~~~~~~
* No longer provide a warning message when both `hub_height` and `clearance_height` are passed to :py:class:`~bifacial_radiance.AnalysisObj.moduleAnalysis` (:pull:`540`)
* More useful __repr__ output in :py:class:`~bifacial_radiance.AnalysisObj and :py:class:`~bifacial_radiance.MetObj (:issue:`471`)
* More useful __repr__ output in :py:class:`~bifacial_radiance.AnalysisObj and :py:class:`~bifacial_radiance.MetObj` (:issue:`471`)

Contributors
~~~~~~~~~~~~
Expand Down
10 changes: 3 additions & 7 deletions docs/tutorials/8 - Electrical Mismatch Method.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -105,24 +105,20 @@
"Created 1axis_2021-11-06_0800.oct\n",
"Created 1axis_2021-11-06_0900.oct\n",
"Created 1axis_2021-11-06_1000.oct\n",
"sceneDict Warning: 'hub_height' and 'clearance_height' are being passed. Using hub_height and removing clearance_height\n",
"Linescan in process: 1axis_2021-11-06_0800_Front\n",
"Linescan in process: 1axis_2021-11-06_0800_Back\n",
"Saved: results\\irr_1axis_2021-11-06_0800.csv\n",
"Index: 2021-11-06_0800. Wm2Front: 216.76329999999996. Wm2Back: 6.098131166666666\n",
"sceneDict Warning: 'hub_height' and 'clearance_height' are being passed. Using hub_height and removing clearance_height\n",
"Index: 2021-11-06_0800. Wm2Front: 217.21925833333333. Wm2Back: 6.115893083333334\n",
"Linescan in process: 1axis_2021-11-06_0900_Front\n",
"Linescan in process: 1axis_2021-11-06_0900_Back\n",
"Saved: results\\irr_1axis_2021-11-06_0900.csv\n",
"Index: 2021-11-06_0900. Wm2Front: 372.0182416666666. Wm2Back: 34.83552916666667\n",
"sceneDict Warning: 'hub_height' and 'clearance_height' are being passed. Using hub_height and removing clearance_height\n",
"Index: 2021-11-06_0900. Wm2Front: 373.20349166666665. Wm2Back: 34.79393916666667\n",
"Linescan in process: 1axis_2021-11-06_1000_Front\n",
"Linescan in process: 1axis_2021-11-06_1000_Back\n",
"Saved: results\\irr_1axis_2021-11-06_1000.csv\n",
"Index: 2021-11-06_1000. Wm2Front: 335.4062166666667. Wm2Back: 40.55148166666667\n",
"Index: 2021-11-06_1000. Wm2Front: 337.41221666666667. Wm2Back: 40.40333416666667\n",
"Saving a cumulative-results file in the main simulation folder.This adds up by sensor location the irradiance over all hours or configurations considered.\n",
"Warning: This file saving routine does not clean results, so if your setup has ygaps, or 2+modules or torque tubes, doing a deeper cleaning and working with the individual results files in the results folder is highly suggested.\n",
"sceneDict Warning: 'hub_height' and 'clearance_height' are being passed. Using hub_height and removing clearance_height\n",
"\n",
"Saving Cumulative results\n",
"Saved: cumulative_results_.csv\n"
Expand Down

0 comments on commit b3818f6

Please sign in to comment.