Test floris #363
Merged
Test floris #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
johnjasa
approved these changes
Oct 16, 2024
johnjasa
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Looks like we might be missing a floris config file that you might have locally as part of this commit; could you please update this PR? https://github.com/NREL/HOPP/actions/runs/11357651664/job/31590877596?pr=363#step:6:230
johnjasa
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for FLORIS
This PR adds tests for the FLORIS capabilities in HOPP. The tests do not have meaningful values other than what I got when running the code locally. This PR also updates the hybrid tests for wind only with a new tolerance because the existing tolerance was so large as to be meaningless.
Related issue
#357
Impacted areas of the software
tests/hopp/test_wind.pytests/hopp/test_hybrid.pyAdditional supporting information
This PR is a critical step towards updating the FLORIS version used by HOPP.
Test results, if applicable
All tests are passing locally.