Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small updates to get things working with Green Steel #210

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Small updates to get things working with Green Steel #210

merged 3 commits into from
Aug 31, 2023

Conversation

ereznicek
Copy link
Collaborator

All edits are to hopp/to_organize/ files so this should not affect anyone else's work

jaredthomas68
jaredthomas68 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@jaredthomas68 jaredthomas68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few bits of code being changed here that are project specific. We should work on making the HOPP elements of the green steel project more general. However, for now I think we will stick with this as is.

@ereznicek ereznicek merged commit f1f8c4f into NREL:dev/refactor Aug 31, 2023
1 check passed
@jaredthomas68 jaredthomas68 mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredthomas68 jaredthomas68 jaredthomas68 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ereznicek @jaredthomas68