-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site info refactor #201
Closed
Closed
Site info refactor #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…section/equations used or repurposed from this analysis.
…Add example yaml file for floating
…Add example yaml file for floating
…to feature/offshore-h2
… variable names to match Orbit Nomenclature in yamls in .py
…cal report and update to test file
Remove Project code
…modules. pushed along to the point that green_steel_ammonia_define_scenarios.py runs.
reconciliation between ckiefer and cfrontin changes
Feature/offshore h2
Green steel cleanup
Added and changed some files to get green steel code to work
* Remove redundant resource files * Fix clustering tests * Remove unneeded tests We determined in our last Refactor meeting that these are not real tests and should be removed. * Limit shapely version There's currently a range of shapely versions that work for HOPP, and this is reflected in `master`. If we want to loosen this constraint, we'll need to figure out why the tests fail on current versions of the package. * Fix test_csp imports * Revert PySAM to 3.0.0 This change broke tests in tests/hopp/test_hybrid, I'm not sure why, but we'll need to revisit if we want to upgrade. * Fix documentation build * Disable test_pressure_vessel * Fix test_custom_financial * Reorganize tests into tests/hopp * Disable analysis tests Met with Kaitlin Brunik (@kbrunik) today to discuss these particular analysis tests. These are based on outdated examples, and need to be re-assessed alongside the code in the holdover `to_organize` directory, which contains a number of files that likely belong as project code rather than usage examples for the repository. * Update Custom Financial Model (NREL#195) * pull in changes from pysam_update_capacity * fix import * update tests * undo a commenting * BatteryStateless (NREL#196) * pull in changes from pysam_update_capacity * fix import * update tests * add batttery_stateless * break out create_max_gross_profit_objective by tech * fix tests * fix minor comments * update .gitignore * Remove more resource files Another attempt at removing files that are not explicitly used in the code. * Re-add clobbered changes and fix imports --------- Co-authored-by: Darice L Guittet <[email protected]> Co-authored-by: Jared Thomas <[email protected]>
This reverts commit 12ba476.
…to dev/refactor
Everything works the same, but now users will need to specify `wind=False` or `solar=False` in the initialization of `SiteInfo`, rather than modifying the data dictionary with `no_wind` or `no_solar`.
…_info_refactor
Something isn't quite right here, I think I used an outdated branch. Going to open a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.