Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed platform citations and comments added. Updated function calls to be consistent with ORBIT 1.06. #107

Merged
merged 6 commits into from
Jul 20, 2023

Conversation

nRiccobo
Copy link
Contributor

Added ORBIT citation and references. Commented each function, citing reference section/equations used or repurposed from this analysis. Also included additional resource that cites default values.

@nRiccobo
Copy link
Contributor Author

nRiccobo commented Jun 12, 2023

In a recent release of ORBIT 1.06, the _design_phases changed from a list to a tuple data type. Therefore, previous calls that use _design_phase.append() no longer apply.

I updated any .append() calls in the test section of fixed_platform.py to use the register_design_phase() and register_install_phase() modules. Now, the new phase argument gets added and treated as any phase in ORBIT.

@jaredthomas68 might be interested in this new PR

@nRiccobo nRiccobo changed the title fixed platform citations and comments added. fixed platform citations and comments added. Updated function calls to be consistent with ORBIT 1.06. Jun 12, 2023
@@ -30,8 +36,9 @@
"""
'''
Notes:
Thank you Jake Nunemaker's oswh2 repository!!!
pile_cost=0 $US/tonne for monopile construction. Not a bug, this # is consistent with the rest of ORBIT
- Thank you Jake Nunemaker's oswh2 repository!!!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point me to this repository? It sounds helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just a private repository that Jake shared with me from a previous offshore-h2 analysis. We'd have to reach out to him for access.

Topside Mass is the required Mass the platform will hold
Topside Cost is a function of topside mass, fab cost and design cost'''
topside_cost = topside_mass *topside_fab_cost_rate +topside_design_cost

'''Substructure
'''Substructure (repurposed eq. 2.31-2.33)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what reference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be from [2]. I'll update the comment.

@jaredthomas68 jaredthomas68 merged commit 74d4363 into NREL:feature/offshore-h2 Jul 20, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants