-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed platform citations and comments added. Updated function calls to be consistent with ORBIT 1.06. #107
fixed platform citations and comments added. Updated function calls to be consistent with ORBIT 1.06. #107
Conversation
…section/equations used or repurposed from this analysis.
…to feature/offshore-h2
In a recent release of ORBIT 1.06, the _design_phases changed from a list to a tuple data type. Therefore, previous calls that use _design_phase.append() no longer apply. I updated any .append() calls in the test section of fixed_platform.py to use the register_design_phase() and register_install_phase() modules. Now, the new phase argument gets added and treated as any phase in ORBIT. @jaredthomas68 might be interested in this new PR |
@@ -30,8 +36,9 @@ | |||
""" | |||
''' | |||
Notes: | |||
Thank you Jake Nunemaker's oswh2 repository!!! | |||
pile_cost=0 $US/tonne for monopile construction. Not a bug, this # is consistent with the rest of ORBIT | |||
- Thank you Jake Nunemaker's oswh2 repository!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you point me to this repository? It sounds helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was just a private repository that Jake shared with me from a previous offshore-h2 analysis. We'd have to reach out to him for access.
hopp/offshore/fixed_platform.py
Outdated
Topside Mass is the required Mass the platform will hold | ||
Topside Cost is a function of topside mass, fab cost and design cost''' | ||
topside_cost = topside_mass *topside_fab_cost_rate +topside_design_cost | ||
|
||
'''Substructure | ||
'''Substructure (repurposed eq. 2.31-2.33) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be from [2]. I'll update the comment.
Added ORBIT citation and references. Commented each function, citing reference section/equations used or repurposed from this analysis. Also included additional resource that cites default values.