SBT integration #284
Merged
SBT integration #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repartion for updating it
…statiated; moved total_drilling_length witin wellbores
…ated an average depth for an SBT reservoir for hydrostatic pressure calculation
…rformance of Eavor-Loop 2.0 Koenraad F. Beckers, Henry E. Johnston (2022)
malcolm-dsider
added
the
enhancement
malcolm-dsider
requested review from
softwareengineerprogrammer and
kfbeckers
softwareengineerprogrammer
requested changes
Sep 2, 2024
softwareengineerprogrammer
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Looks good from code perspective now - suggest @kfbeckers review for model accuracy before merging
Closed
3 tasks
|
TODO post-merge: audit whether any of the following issues have been addressed by this PR:
|
kfbeckers
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slender Body Theory (SBT) alternative reservoir/wells/economics integrated into GEOPHIRES. It handless the Eavor Loop 1.0 and 2.0 styles. Test files that reproduce the results for the low-T and High-t cases from the paper: Techno-Economic Performance of Eavor-Loop 2.0 Koenraad F. Beckers, Henry E. Johnston (2022) are included. This paper is the basis for the SBT algorithm. It was converted from MatLab code published with paper.