PR 185 Cleanup #193
Merged
PR 185 Cleanup #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up-2 PR 185 Follow up (rebased)
malcolm-dsider
approved these changes
Apr 30, 2024
…#issuecomment-2086009787 for now - appears to experience intermittent failures in GH Actions
| def lithostatic_pressure(self, rho_rock_kg_per_m3: float, depth_m: float) -> PlainQuantity: | ||
| return quantity(static_pressure_MPa(rho_rock_kg_per_m3, depth_m), 'MPa') | ||
| return quantity(static_pressure_MPa(self.rhorock.quantity().to('kg/m**3').magnitude, | ||
| self.InputDepth.quantity().to('m').magnitude), 'MPa') |
There was a problem hiding this comment.
Tangentially relevant to #122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #185 (self-reviewed in softwareengineerprogrammer#22)
lithostatic_pressureas an overridden class method inCylindricalReservoirinstead of passing parameters fromWellBoresfor less code duplication and better consistency; plus other related code cleanup