Fix Revenue & Cashflow Profile Units, Update Utilization Efficiency (v3.4.16) #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill be broken and will be updated next)
…ow-unit-fix Revenue cashflow unit fix
…les that contain them, based on date of last functional change in git history
malcolm-dsider
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Looks good - it would be good to have a code review on best practices for using Pint now that Pint is becoming mainstream for us.
Also, note that the free forex_pythton seems to have stopped working - it looks like the service it is hitting is no longer free. That library handles real-time currency exchange for us. We don't use it much, but we may have to deprecate its use entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example1_addons.txtwith new carbon/addon calculation variable names