Increase Slat Angle Sampling Frequency for Blind Properties #10646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirroth
added
the
SeverityLow
amirroth
requested review from
yujiex,
Myoldmopar and
vidanovic
and removed request for
yujiex
amirroth
commented
Aug 7, 2024
| @@ -61,7 +61,7 @@ namespace EnergyPlus { | |||
|
|
|||
| namespace Material { | |||
|
|
|||
| constexpr int MaxSlatAngs(19); | |||
| constexpr int MaxSlatAngs(181); // 1 degree increments for slat angles (We'll see what the performance implications are) | |||
There was a problem hiding this comment.
This is the only real change.
| @@ -5833,7 +5833,7 @@ namespace Window { | |||
| DPhi = 5.0 * Constant::DegToRadians; | |||
|
|
|||
| // Integrate from -90 to 0 deg | |||
| for (int IPhi = 1; IPhi <= 18; ++IPhi) { | |||
| for (int IPhi = 1; IPhi <= (Material::MaxProfAngs / 2); ++IPhi) { | |||
There was a problem hiding this comment.
Noticed that these are literals so changed to use the constexpr int MaxProfAngs. That is all.
|
I'll run clang format here and get this merged in. |
Myoldmopar
added
Defect
|
Looks happy enough, let's merge this. Thanks @amirroth |
Myoldmopar
added a commit
that referenced
this pull request
Sep 3, 2024
Fix Bug Uncovered in PR #10646
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue summarizes the underlying problem and its solution. TL;DR fixed-slat and movable-slat blinds used two different calculation methods for blind properties, direct calculation at the slat angle for fixed and interpolation between pre-calculated values sampled at 10 degree intervals for movable. This was found to cause meaningful differences between fixed-slat blinds and movable-slat blinds with the slats in the same position (specifically and especially the default 45 degrees). Some notable differences remained when the sampling period was reduced to 5 degrees, and so the period was further reduced to 1 degree.
"Errors" are expected in the three test files that use movable-slat blinds.
This issue was uncovered during the course of a refactor. The resolution is being packaged in a separate PR in order to isolate the output changes.
Comments and follow-up from @mjwitte and @vidanovic in the issue itself.