Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Conduction Transfer Function time step limit #10614

Merged
merged 1 commit into from
Jul 31, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/EnergyPlus/Construction.cc
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,15 @@ void ConstructionProps::calculateTransferFunction(EnergyPlusData &state, bool &E
// greater than this, then the coefficients will not yield a valid steady
// state solution.

constexpr Real64 MaxAllowedTimeStep(4.0); // Sets the maximum allowed time step
// for CTF calculations to be 4 hours. This is done in response to some
constexpr Real64 MaxAllowedTimeStep = 7.0; // Sets the maximum allowed time step
// for CTF calculations to be 7 hours. This is done in response to some
// rare situations where odd or faulty input will cause the routine to
// go off and get some huge time step (in excess of 20 hours). This value
// is a compromise that does not really solve any input problems. One run
// indicated that 2 meters of concrete will result in a time step of slightly
// more than 3 hours. So, 4 hours was arbitrarily picked as a ceiling for
// more than 3 hours. So, 7 hours was arbitrarily picked as a ceiling for
// time steps so that an error message can be produced to warn the user
// that something isn't right. Note that the 4 hour limit does not guarantee
// that something isn't right. Note that the 7 hour limit does not guarantee
// that problems won't exist and it does not necessarily avoid any problems
// that interpolated temperature histories might cause.

Expand Down
Loading