-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Floating point exceptions by default in Debug mode (GCC/Clang) #10578
Merged
Merged
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
dcd3358
Enable Floating point exceptions by default in Debug mode (?)
jmarrec 0146701
Fix RefrigeratedRackWithCaseInZone by initializing OutBaroPress
jmarrec b43c6d5
CurveManager: when divisor is zero, don't try to exercise it
jmarrec 268de04
Fix CO2ControlDesignOccupancyTest
jmarrec 40cb547
Fix WindowManager_RefAirTempTest by properly allocating arrays
jmarrec 6686e0c
Work around for DXCoils_Test1
jmarrec 409f804
Fix HPWHSizing
jmarrec 7d4e4fa
Fix VariableSpeedCoils_ZeroRatedCoolingCapacity_Test
jmarrec d54533c
Fix SolarShadingTest_CalcBeamSolarOnWinRevealSurface
jmarrec 8945549
Fix ManageElectricPowerTest_CheckOutputReporting
jmarrec 0834394
Fix UnitaryBypassVAV_ParentElectricityRateTest
jmarrec 9cdb3e4
Fix HVACMSHP_UnitarySystemElectricityRateTest
jmarrec a0b20cc
Similar fix for PTHP test: init the RatedAirMassFlowRate due to sizin…
jmarrec e92b7e8
Fix TestReadingCoilCoolingHeatingDX
jmarrec 30fdefb
Fix SingleSpeedDXCoolingCoilOutputTest
jmarrec 9fa8ee0
Fix MultiSpeedDXCoolingCoilOutputTest
jmarrec 2dee72c
Fix SQLiteFixture.DXCoils_TestComponentSizingOutput_SingleSpeed / DXC…
jmarrec 023b7f8
Fix EnergyPlusFixture.TwoSpeedDXCoilStandardRatings_Curve_Fix_Test E…
jmarrec 64018cf
Catch floating point exceptions on MSVC for gtest + add cmake `FORCE_…
jmarrec 6cf3c3e
Merge remote-tracking branch 'origin/develop' into enable_fe_default_…
jmarrec b6be21a
Fix 5 DX coil unit tests
rraustad 7220b7b
Fixed crash, now get diffs in solar shading
rraustad aa433a7
clang format
jmarrec bbfe61b
Use relatistic SUNCOSTS
jmarrec 5c09ebf
Merged develop; resolved conflicts
Myoldmopar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2212,7 +2212,7 @@ TEST_F(EnergyPlusFixture, AirflowNetwork_TestPressureStat) | |
|
||
// Check indoor pressure and mass flow rate | ||
EXPECT_NEAR(PressureSet, state->afn->AirflowNetworkNodeSimu(3).PZ, 0.0001); | ||
EXPECT_NEAR(0.00255337, state->afn->ReliefMassFlowRate, 0.0001); | ||
EXPECT_NEAR(0.06551, state->afn->ReliefMassFlowRate, 0.0001); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume since StdRhoAir is now in the fixture that something has changed BEFORE this unit test sets StdRhoAir. |
||
|
||
// Start a test for #5687 to report zero values of AirflowNetwork:Distribution airflow and pressure outputs when a system is off | ||
state->afn->AirflowNetworkFanActivated = false; | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be a better way to correct this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.