Testing for diffs as part of 9979 that are needed for proper plant simulation

[rraustad]

Pull request overview

• Fixes an issue with plant simulations where component is on inlet node of plant
• DESCRIBE PURPOSE OF THIS PULL REQUEST

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

Verify these changes cause the diffs on #9979:

[mjwitte]

This confirms the source of the diffs, but I don't see anything here or in #9979 that discusses the magnitude of the diffs, annual energy impact, some examples of how this is better than before. If it's significant then I'd rather see this PR go in first to highlight the fix and it's impact and reduce the diffs in #9979.

[Myoldmopar]

@mjwitte or @rraustad : Could you confirm the branch status here? There are a few branches I'd like to prune and this looks like it was mostly a precursor to #9979, which was already merged.

[rraustad]

This branch can be deleted. This code is in develop, just commented out for the time being and comment points to this branch. For example:

    // see 10133
    // state.dataLoopNodes->Node(OutletNodeNum).MassFlowRate =
    //    state.dataLoopNodes->Node(InletNodeNum).MassFlowRate; // if heat recovery bundle is on inlet branch, the mass flow needs to be
    //// updated or get splitter/mixer failures