Skip to content

Commit

Permalink
10299 Correction of Unit Test enum
Browse files Browse the repository at this point in the history
Correction of enum comparisons to eliminate errors in energyplus_tests
  • Loading branch information
RKStrand committed Jul 19, 2024
1 parent 608530e commit ce283a3
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions tst/EnergyPlus/unit/SolarShading.unit.cc
Original file line number Diff line number Diff line change
Expand Up @@ -5984,7 +5984,7 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest1)
EXPECT_EQ(expectedOverlaps, state->dataSolarShading->MaxHCS);
EXPECT_FALSE(state->dataSysVars->SutherlandHodgman);
EXPECT_FALSE(state->dataSysVars->SlaterBarsky);
EXPECT_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PolygonClipping);
EXPECT_ENUM_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PolygonClipping);
}

TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest2)
Expand Down Expand Up @@ -6017,7 +6017,7 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest2)
EXPECT_EQ(expectedOverlaps, state->dataSolarShading->MaxHCS);
EXPECT_TRUE(state->dataSysVars->SutherlandHodgman);
EXPECT_FALSE(state->dataSysVars->SlaterBarsky);
EXPECT_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PolygonClipping);
EXPECT_ENUM_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PolygonClipping);
}

TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest3)
Expand Down Expand Up @@ -6050,7 +6050,7 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest3)
EXPECT_EQ(expectedOverlaps, state->dataSolarShading->MaxHCS);
EXPECT_TRUE(state->dataSysVars->SutherlandHodgman);
EXPECT_TRUE(state->dataSysVars->SlaterBarsky);
EXPECT_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PolygonClipping);
EXPECT_ENUM_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PolygonClipping);
}

TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest4)
Expand Down Expand Up @@ -6083,7 +6083,7 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest4)
EXPECT_EQ(expectedOverlaps, state->dataSolarShading->MaxHCS);
EXPECT_FALSE(state->dataSysVars->SutherlandHodgman);
EXPECT_FALSE(state->dataSysVars->SlaterBarsky);
EXPECT_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PixelCounting);
EXPECT_ENUM_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PixelCounting);
}

TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest5)
Expand Down Expand Up @@ -6116,7 +6116,7 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest5)
EXPECT_EQ(expectedOverlaps, state->dataSolarShading->MaxHCS);
EXPECT_TRUE(state->dataSysVars->SutherlandHodgman);
EXPECT_FALSE(state->dataSysVars->SlaterBarsky);
EXPECT_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PixelCounting);
EXPECT_ENUM_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PixelCounting);
}

TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest6)
Expand Down Expand Up @@ -6150,7 +6150,7 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_GetShadowingInputTest6)
EXPECT_EQ(expectedOverlaps, state->dataSolarShading->MaxHCS);
EXPECT_TRUE(state->dataSysVars->SutherlandHodgman);
EXPECT_TRUE(state->dataSysVars->SlaterBarsky);
EXPECT_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PixelCounting);
EXPECT_ENUM_EQ(state->dataSysVars->shadingMethod, ShadingMethod::PixelCounting);
std::string const error_string = delimited_string({" ** Warning ** ShadowCalculation: suspect Shading Calculation Update Frequency",
" ** ~~~ ** Value entered=[56], Shadowing Calculations will be inaccurate."});
EXPECT_TRUE(compare_err_stream(error_string, true));
Expand Down

1 comment on commit ce283a3

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10299CheckConvexityChangeCheckForShadowCalculations (RKStrand) - x86_64-MacOS-10.18-clang-15.0.0: OK (3650 of 3650 tests passed, 787 test warnings)

Messages:\n

  • 787 tests had: EIO diffs.
  • 1 test had: ERR diffs.

Build Badge Test Badge

Please sign in to comment.