Skip to content

Commit

Permalink
Use relatistic SUNCOSTS
Browse files Browse the repository at this point in the history 
Gotten from running 1ZoneUncontrolled.idf with chicago weather on Jan 1 at 12
  • Loading branch information
@jmarrec
jmarrec committed Aug 14, 2024
1 parent aa433a7 commit bbfe61b
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions tst/EnergyPlus/unit/SolarShading.unit.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1880,6 +1880,10 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_PolygonClippingDirect)
SolarShading::SkyDifSolarShading(*state);
state->dataSolarShading->CalcSkyDifShading = false;

state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(1) = 0.20531446332266728;
state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(2) = -0.84761109808931534;
state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(3) = 0.48928662105799514;

FigureSolarBeamAtTimestep(*state, state->dataGlobal->HourOfDay, state->dataGlobal->TimeStep);
int surfNum = Util::FindItemInList("ZN001:WALL-SOUTH:WIN001", state->dataSurface->Surface);
EXPECT_NEAR(0.6504, state->dataSolarShading->SurfDifShdgRatioIsoSkyHRTS(4, 9, surfNum), 0.0001);
Expand Down Expand Up @@ -4698,9 +4702,11 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_PolygonOverlap2)
shade2SchedEMSOn = true;
shade1SchedEMSValue = 1.0;
shade2SchedEMSValue = 1.0;
state->dataBSDFWindow->SUNCOSTS(4, 12)(1) = 0.2;
state->dataBSDFWindow->SUNCOSTS(4, 12)(2) = 0.2;
state->dataBSDFWindow->SUNCOSTS(4, 12)(3) = 0.2;

// Gotten from running 1ZoneUncontrolled.idf with chicago weather on Jan 1 at 12
state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(1) = 0.20531446332266728;
state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(2) = -0.84761109808931534;
state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(3) = 0.48928662105799514;
FigureSolarBeamAtTimestep(*state, state->dataGlobal->HourOfDay, state->dataGlobal->TimeStep);
ReportSurfaceShading(*state);

Expand Down Expand Up @@ -5048,9 +5054,9 @@ TEST_F(EnergyPlusFixture, SolarShadingTest_PolygonOverlap3)

// Use the base transmittance schedules (no EMS override)
// shade1 transmittance = 0.5, shade2 transmittance = 0.8
state->dataBSDFWindow->SUNCOSTS(4, 12)(1) = 0.2;
state->dataBSDFWindow->SUNCOSTS(4, 12)(2) = 0.2;
state->dataBSDFWindow->SUNCOSTS(4, 12)(3) = 0.2;
state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(1) = 0.20531446332266728;
state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(2) = -0.84761109808931534;
state->dataBSDFWindow->SUNCOSTS(state->dataGlobal->TimeStep, state->dataGlobal->HourOfDay)(3) = 0.48928662105799514;
FigureSolarBeamAtTimestep(*state, state->dataGlobal->HourOfDay, state->dataGlobal->TimeStep);
ReportSurfaceShading(*state);

Expand Down

4 comments on commit bbfe61b

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_fe_default_debug (jmarrec) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3698 of 3698 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_fe_default_debug (jmarrec) - x86_64-MacOS-10.18-clang-15.0.0: OK (3657 of 3657 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_fe_default_debug (jmarrec) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (796 of 796 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_fe_default_debug (jmarrec) - Win64-Windows-10-VisualStudio-16: OK (2864 of 2864 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.