Skip to content

Commit

Permalink
Revert "change default value of MaxHeat(Cool)ingCapacity to MaxCap"
Browse files Browse the repository at this point in the history
This reverts commit 1c35238.
  • Loading branch information
Yujie Xu committed Sep 4, 2024
1 parent 1c35238 commit acb84a0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/EnergyPlus/HVACVariableRefrigerantFlow.cc
Original file line number Diff line number Diff line change
Expand Up @@ -11491,7 +11491,7 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c

this->HeatingCapacity = 0.0; // Include the piping loss
this->PipingCorrectionHeating = 1.0; // 1 means no piping loss
state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond) = MaxCap;
state.dataHVACVarRefFlow->MaxHeatingCapacity(VRFCond) = 0.0;

this->OUCondHeatRate = Q_h_OU;
this->OUEvapHeatRate = 0;
Expand Down Expand Up @@ -11722,8 +11722,8 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state, c
this->HeatingCapacity; // for report, maximum condensing capacity the system can provide

this->CoolingCapacity = 0.0; // Include the piping loss
this->PipingCorrectionCooling = 1.0;
state.dataHVACVarRefFlow->MaxCoolingCapacity(VRFCond) = MaxCap; // for report
this->PipingCorrectionCooling = 0.0;
state.dataHVACVarRefFlow->MaxCoolingCapacity(VRFCond) = 0.0; // for report

this->OUCondHeatRate = 0;
this->OUEvapHeatRate = Q_c_OU;
Expand Down

4 comments on commit acb84a0

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2852 of 2852 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: Tests Failed (3245 of 3685 tests passed, 355 test warnings)

Messages:\n

  • 594 tests had: AUD diffs.
  • 791 tests had: EIO diffs.
  • 208 tests had: ESO small diffs.
  • 186 tests had: MTR small diffs.
  • 434 tests had: Table big diffs.
  • 284 tests had: RDD diffs.
  • 5 tests had: BND diffs.
  • 26 tests had: ESO big diffs.
  • 4 tests had: MTD diffs.
  • 14 tests had: MTR big diffs.
  • 65 tests had: Table string diffs.
  • 37 tests had: ERR diffs.
  • 18 tests had: Table small diffs.
  • 2 tests had: EDD diffs.
  • 1 test had: JSON big diffs.
  • 1 test had: MDD diffs.
  • 1 test had: IDF diffs.

Failures:\n

regression Test Summary

  • Passed: 371
  • Failed: 440

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2060 of 2060 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfFluidCtrlFixCoolingCycling (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (795 of 795 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.