Skip to content

Commit

Permalink
add fan heat gain adjustment
Browse files Browse the repository at this point in the history
  • Loading branch information
Yujie Xu authored and Yujie Xu committed Jan 24, 2024
1 parent 5a00a65 commit 9a0cc0b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/EnergyPlus/HVACVariableRefrigerantFlow.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12507,6 +12507,7 @@ void VRFCondenserEquipment::CalcVRFCondenser_FluidTCtrl(EnergyPlusData &state)
// this is not the case for heating
fan.FanPower *= coolingCoil.CoolingCoilRuntimeFraction;
fan.FanEnergy = fan.FanPower * state.dataHVACGlobal->TimeStepSysSec;
fan.PowerLossToAir *= coolingCoil.CoolingCoilRuntimeFraction;
}
}
}
Expand Down

5 comments on commit 9a0cc0b

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2757 of 2759 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1482
  • Failed: 2

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: Tests Failed (3028 of 3587 tests passed, 233 test warnings)

Messages:\n

  • 789 tests had: AUD diffs.
  • 634 tests had: EIO diffs.
  • 15 tests had: EDD diffs.
  • 518 tests had: ESO big diffs.
  • 510 tests had: Table big diffs.
  • 132 tests had: MTR big diffs.
  • 268 tests had: ZSZ big diffs.
  • 143 tests had: ESO small diffs.
  • 83 tests had: Table small diffs.
  • 395 tests had: MTR small diffs.
  • 92 tests had: ERR diffs.
  • 169 tests had: SSZ big diffs.
  • 69 tests had: SSZ small diffs.
  • 25 tests had: MTD diffs.
  • 10 tests had: MDD diffs.
  • 1 test had: JSON big diffs.
  • 33 tests had: ZSZ small diffs.
  • 1 test had: PERF_LOG diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1484
  • Failed: 1
  • SEGFAULT: 1

regression Test Summary

  • Passed: 249
  • Failed: 557

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1970 of 1972 tests passed, 0 test warnings)

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1484
  • Failed: 1
  • Subprocess aborted: 1

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (790 of 790 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrfCoolingFan (Unknown) - x86_64-MacOS-10.18-clang-15.0.0: Tests Failed (2988 of 3546 tests passed, 231 test warnings)

Messages:\n

  • 785 tests had: AUD diffs.
  • 630 tests had: EIO diffs.
  • 15 tests had: EDD diffs.
  • 516 tests had: ESO big diffs.
  • 508 tests had: Table big diffs.
  • 132 tests had: MTR big diffs.
  • 268 tests had: ZSZ big diffs.
  • 144 tests had: ESO small diffs.
  • 398 tests had: MTR small diffs.
  • 82 tests had: Table small diffs.
  • 91 tests had: ERR diffs.
  • 169 tests had: SSZ big diffs.
  • 69 tests had: SSZ small diffs.
  • 25 tests had: MTD diffs.
  • 10 tests had: MDD diffs.
  • 1 test had: JSON big diffs.
  • 33 tests had: ZSZ small diffs.
  • 1 test had: PERF_LOG diffs.

Failures:\n

EnergyPlusFixture Test Summary

  • Passed: 1484
  • Failed: 1
  • SEGFAULT: 1

regression Test Summary

  • Passed: 231
  • Failed: 555

Build Badge Test Badge

Please sign in to comment.