Skip to content

Commit

Permalink
prevent creating a rootsolver object while saving old value
Browse files Browse the repository at this point in the history
  • Loading branch information
Yujie Xu committed Jul 22, 2024
1 parent ce88b29 commit 7f824c1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/EnergyPlus/ExtendedHI.cc
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,8 @@ namespace ExtendedHI {
// RH: relative humidity in range of 0.0 to 1.0
// The function computes the extended heat index, in Kelvinn

auto const HVACSystemRootSolverBackup = state.dataRootFinder->HVACSystemRootFinding.HVACSystemRootSolver;
auto const &HVACSystemRootSolver = state.dataRootFinder->HVACSystemRootFinding.HVACSystemRootSolver;
auto const HVACSystemRootSolverBackup = HVACSystemRootSolver;
state.dataRootFinder->HVACSystemRootFinding.HVACSystemRootSolver = HVACSystemRootSolverAlgorithm::Bisection;
auto eqvars = find_eqvar(state, Ta, RH);
int eqvar_name = std::get<0>(eqvars);
Expand Down

5 comments on commit 7f824c1

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extendedHI (Unknown) - x86_64-MacOS-10.18-clang-15.0.0: Tests Failed (3136 of 3647 tests passed, 279 test warnings)

Messages:\n

  • 790 tests had: AUD diffs.
  • 599 tests had: EIO diffs.
  • 11 tests had: ESO big diffs.
  • 387 tests had: Table big diffs.
  • 411 tests had: Table string diffs.
  • 1 test had: MTD diffs.
  • 1 test had: ERR diffs.
  • 1 test had: RDD diffs.

Failures:\n

regression Test Summary

  • Passed: 280
  • Failed: 511

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extendedHI (Unknown) - Win64-Windows-10-VisualStudio-16: OK (2855 of 2855 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extendedHI (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: Build Failed

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extendedHI (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: Build Failed

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extendedHI (Unknown) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: Build Failed

Build Badge Test Badge Coverage Badge

Please sign in to comment.