Skip to content

Commit

Permalink
Rename vars in unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@mjwitte
mjwitte committed Aug 25, 2023
1 parent 9658c81 commit 6d094b0
Showing 1 changed file with 15 additions and 17 deletions.
32 changes: 15 additions & 17 deletions tst/EnergyPlus/unit/ZoneTempPredictorCorrector.unit.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1463,23 +1463,21 @@ TEST_F(EnergyPlusFixture, ReportMoistLoadsZoneMultiplier_Test)
thisZone.ListMultiplier = 1.0;
thisZoneSysMoistureDemand.reportMoistLoadsZoneMultiplier(
*state, zoneNum, totalOutputRequired, outputRequiredToHumidifyingSP, outputRequiredToDehumidifyingSP);
EXPECT_NEAR(thisZoneSysMoistureDemand.TotalOutputRequired, thisZoneSysMoistureDemand.ZoneMoisturePredictedRate, AcceptableTolerance);
EXPECT_NEAR(
thisZoneSysMoistureDemand.OutputRequiredToHumidifyingSP, thisZoneSysMoistureDemand.ZoneMoisturePredictedHumSPRate, AcceptableTolerance);
EXPECT_NEAR(
thisZoneSysMoistureDemand.OutputRequiredToDehumidifyingSP, thisZoneSysMoistureDemand.ZoneMoisturePredictedDehumSPRate, AcceptableTolerance);
EXPECT_NEAR(thisZoneSysMoistureDemand.TotalOutputRequired, thisZoneSysMoistureDemand.predictedRate, AcceptableTolerance);
EXPECT_NEAR(thisZoneSysMoistureDemand.OutputRequiredToHumidifyingSP, thisZoneSysMoistureDemand.predictedHumSPRate, AcceptableTolerance);
EXPECT_NEAR(thisZoneSysMoistureDemand.OutputRequiredToDehumidifyingSP, thisZoneSysMoistureDemand.predictedDehumSPRate, AcceptableTolerance);

// Test 2a: Zone Multiplier (non-list) is greater than 1, list Zone Multiplier is still one
thisZone.Multiplier = 7.0;
thisZone.ListMultiplier = 1.0;
thisZoneSysMoistureDemand.reportMoistLoadsZoneMultiplier(
*state, zoneNum, totalOutputRequired, outputRequiredToHumidifyingSP, outputRequiredToDehumidifyingSP);
ExpectedResult = 1000.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedRate, AcceptableTolerance);
ExpectedResult = 2000.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedHumSPRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedHumSPRate, AcceptableTolerance);
ExpectedResult = 3000.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedDehumSPRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedDehumSPRate, AcceptableTolerance);
ExpectedResult = 7000.0;
EXPECT_NEAR(thisZoneSysMoistureDemand.TotalOutputRequired, ExpectedResult, AcceptableTolerance);
ExpectedResult = 14000.0;
Expand All @@ -1493,11 +1491,11 @@ TEST_F(EnergyPlusFixture, ReportMoistLoadsZoneMultiplier_Test)
thisZoneSysMoistureDemand.reportMoistLoadsZoneMultiplier(
*state, zoneNum, totalOutputRequired, outputRequiredToHumidifyingSP, outputRequiredToDehumidifyingSP);
ExpectedResult = 1000.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedRate, AcceptableTolerance);
ExpectedResult = 2000.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedHumSPRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedHumSPRate, AcceptableTolerance);
ExpectedResult = 3000.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedDehumSPRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedDehumSPRate, AcceptableTolerance);
ExpectedResult = 7000.0;
EXPECT_NEAR(thisZoneSysMoistureDemand.TotalOutputRequired, ExpectedResult, AcceptableTolerance);
ExpectedResult = 14000.0;
Expand All @@ -1514,11 +1512,11 @@ TEST_F(EnergyPlusFixture, ReportMoistLoadsZoneMultiplier_Test)
thisZoneSysMoistureDemand.reportMoistLoadsZoneMultiplier(
*state, zoneNum, totalOutputRequired, outputRequiredToHumidifyingSP, outputRequiredToDehumidifyingSP);
ExpectedResult = 300.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedRate, AcceptableTolerance);
ExpectedResult = 150.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedHumSPRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedHumSPRate, AcceptableTolerance);
ExpectedResult = 100.0;
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.ZoneMoisturePredictedDehumSPRate, AcceptableTolerance);
EXPECT_NEAR(ExpectedResult, thisZoneSysMoistureDemand.predictedDehumSPRate, AcceptableTolerance);
ExpectedResult = 1800.0;
EXPECT_NEAR(thisZoneSysMoistureDemand.TotalOutputRequired, ExpectedResult, AcceptableTolerance);
ExpectedResult = 900.0;
Expand All @@ -1532,9 +1530,9 @@ TEST_F(EnergyPlusFixture, ReportSensibleLoadsZoneMultiplier_Test)
int zoneNum = 1;
state->dataZoneEnergyDemand->ZoneSysEnergyDemand.allocate(zoneNum);
auto &thisZoneSysEnergyDemand = state->dataZoneEnergyDemand->ZoneSysEnergyDemand(zoneNum);
Real64 &SingleZoneTotRate = thisZoneSysEnergyDemand.ZoneSNLoadPredictedRate;
Real64 &SingleZoneHeatRate = thisZoneSysEnergyDemand.ZoneSNLoadPredictedHSPRate;
Real64 &SingleZoneCoolRate = thisZoneSysEnergyDemand.ZoneSNLoadPredictedCSPRate;
Real64 &SingleZoneTotRate = thisZoneSysEnergyDemand.predictedRate;
Real64 &SingleZoneHeatRate = thisZoneSysEnergyDemand.predictedHSPRate;
Real64 &SingleZoneCoolRate = thisZoneSysEnergyDemand.predictedCSPRate;
state->dataHeatBalFanSys->LoadCorrectionFactor.allocate(zoneNum);
Real64 &CorrectionFactor = state->dataHeatBalFanSys->LoadCorrectionFactor(zoneNum);
state->dataHeatBal->Zone.allocate(zoneNum);
Expand Down

5 comments on commit 6d094b0

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart2 (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2713 of 2713 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart2 (mjwitte) - x86_64-MacOS-10.17-clang-14.0.0: OK (3497 of 3497 tests passed, 3 test warnings)

Messages:\n

  • 3 tests had: PERF_LOG diffs.

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart2 (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (3538 of 3538 tests passed, 4 test warnings)

Messages:\n

  • 3 tests had: PERF_LOG diffs.
  • 1 test had: Table small diffs.

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart2 (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (1929 of 1929 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpaceSizingHVACPart2 (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (787 of 787 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.