Skip to content

Commit

Permalink
Merge pull request #10614 from NREL/10613-CTF-fails-with-thick-dense-…
Browse files Browse the repository at this point in the history
…material

Relax Conduction Transfer Function time step limit
  • Loading branch information
mjwitte authored Jul 31, 2024
2 parents aa19908 + ede5303 commit 0a139a5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/EnergyPlus/Construction.cc
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,15 @@ void ConstructionProps::calculateTransferFunction(EnergyPlusData &state, bool &E
// greater than this, then the coefficients will not yield a valid steady
// state solution.

constexpr Real64 MaxAllowedTimeStep(4.0); // Sets the maximum allowed time step
// for CTF calculations to be 4 hours. This is done in response to some
constexpr Real64 MaxAllowedTimeStep = 7.0; // Sets the maximum allowed time step
// for CTF calculations to be 7 hours. This is done in response to some
// rare situations where odd or faulty input will cause the routine to
// go off and get some huge time step (in excess of 20 hours). This value
// is a compromise that does not really solve any input problems. One run
// indicated that 2 meters of concrete will result in a time step of slightly
// more than 3 hours. So, 4 hours was arbitrarily picked as a ceiling for
// more than 3 hours. So, 7 hours was arbitrarily picked as a ceiling for
// time steps so that an error message can be produced to warn the user
// that something isn't right. Note that the 4 hour limit does not guarantee
// that something isn't right. Note that the 7 hour limit does not guarantee
// that problems won't exist and it does not necessarily avoid any problems
// that interpolated temperature histories might cause.

Expand Down

5 comments on commit 0a139a5

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4: OK (2884 of 2884 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mjwitte) - x86_64-MacOS-10.18-clang-15.0.0: OK (2863 of 2863 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2862 of 2862 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-UnitTestsCoverage-Debug: OK (2070 of 2070 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mjwitte) - x86_64-Linux-Ubuntu-22.04-gcc-11.4-IntegrationCoverage-Debug: OK (795 of 795 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.