Bugfix 1.7.1 - Fix bad listeners detachment for characteristics (#563)

CHANGELOG.md

@@ -9,6 +9,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres
 to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.7.1] - 2024-09-24
+
+### Fixed
+
+- Fix bad listeners detachment for characteristics [#563](https://github.com/NRCHKB/node-red-contrib-homekit-bridged/issues/563)
+
 ## [1.7.0] - 2024-09-19
 
 ### Fixed

package.json

@@ -1,6 +1,6 @@
 {
  "name": "node-red-contrib-homekit-bridged",
- "version": "1.7.0",
+ "version": "1.7.1",
  "description": "Node-RED nodes to simulate Apple HomeKit devices.",
  "main": "build/nodes/nrchkb.js",
  "scripts": {

src/lib/utils/CharacteristicUtils.ts

@@ -64,20 +64,21 @@ module.exports = function (node: HAPServiceNodeType) {
  service.optionalCharacteristics
  )
 
+ // Listen to characteristic events and store the listener functions
+ // to be able to remove them later
+ node.onCharacteristicGet = ServiceUtils.onCharacteristicGet
+ node.onCharacteristicSet = ServiceUtils.onCharacteristicSet(
+ service.characteristics
+ )
+ node.onCharacteristicChange = ServiceUtils.onCharacteristicChange(
+ service.characteristics
+ )
+
  allCharacteristics.map((characteristic) => {
  const cKey = characteristic.constructor.name
 
  supported.push(cKey)
 
- // Listen to characteristic events and store the listener functions
- // to be able to remove them later
- node.onCharacteristicGet = ServiceUtils.onCharacteristicGet
- node.onCharacteristicSet = ServiceUtils.onCharacteristicSet(
- service.characteristics
- )
- node.onCharacteristicChange = ServiceUtils.onCharacteristicChange(
- service.characteristics
- )
  characteristic.on('get', node.onCharacteristicGet)
  characteristic.on('set', node.onCharacteristicSet)
  characteristic.on('change', node.onCharacteristicChange)

src/lib/utils/CharacteristicUtils2.ts

@@ -64,22 +64,23 @@ module.exports = function (node: HAPService2NodeType) {
  service.optionalCharacteristics
  )
 
+ // Listen to characteristic events and store the listener functions
+ // to be able to remove them later
+ node.onCharacteristicGet = ServiceUtils.onCharacteristicGet(
+ service.characteristics
+ )
+ node.onCharacteristicSet = ServiceUtils.onCharacteristicSet(
+ service.characteristics
+ )
+ node.onCharacteristicChange = ServiceUtils.onCharacteristicChange(
+ service.characteristics
+ )
+
  allCharacteristics.map((characteristic) => {
  const cKey = characteristic.constructor.name
 
  supported.push(cKey)
 
- // Listen to characteristic events and store the listener functions
- // to be able to remove them later
- node.onCharacteristicGet = ServiceUtils.onCharacteristicGet(
- service.characteristics
- )
- node.onCharacteristicSet = ServiceUtils.onCharacteristicSet(
- service.characteristics
- )
- node.onCharacteristicChange = ServiceUtils.onCharacteristicChange(
- service.characteristics
- )
  characteristic.on('get', node.onCharacteristicGet)
  characteristic.on('set', node.onCharacteristicSet)
  characteristic.on('change', node.onCharacteristicChange)