coastal_boundary dataframe with hourly SCHISM data in Hyfeature unit test #601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, multi hourly schism data was used as one of the downstream boundary condition for diffusive routing. To be consistent with hourly lateral forcing data, hourly SCHISM data has been created from the multi hourly data and preprocess codes for creating coastal boundary depth dataframe has been modified, which includes add downstream boundary file attribute to run_sets.
Note that, for example, total simulation of 4 hrs with max_time_loop of 2hrs requires two sets of lateral forcing in run_sets: the first set of qlat data at t0 and t0+1hr and the second set at t0+2hr and t0+3hr. However, two sets of SCHISM data needed for this run are, first, SCHISM data at t0, t0+1hr, and t0+2hr and, second, SCHISM data at t0+2hr, t0+3hr, and t0+4hr.
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other