Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config, install, readme & realization updates #23

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

madMatchstick
Copy link
Contributor

Minor non-code updates

Changes

  1. config.txt(s): all instances of sft_coupled to is_sft_coupled per cfe pr #105
  2. INSTALL.md:
    1. add -DNGEN_IS_MAIN_PROJECT=ON flag to the noah-owp-modular lib build
    2. Remove sft submodule update from LASAM build (not officially listed in ngen/extern)
    3. Some markdown syntax changes for better c/p
  3. example/README.md: dir test already exists, suggest ngen/test_sft
  4. realizations/realization_standalone.json: update sft lib path

Todos

  1. Need to revisit the instructions for "Example 3: Integrated models (SLoTH+SMP+SFT+CFE/LASAM) example with NOAH-OWP-Mod". Perhaps some pathing and/or symbolic linkage is off?
  2. Couple general questions regarding install,
    1. Why are we updating some submodules but not others?
    2. Why ngen build to include PYTHON and SQLITE for this particular workflow(s)?

Copy link
Collaborator

@ajkhattak ajkhattak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for the updates...

@ajkhattak ajkhattak marked this pull request as ready for review March 20, 2024 19:06
@ajkhattak ajkhattak merged commit 1b6d660 into master Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants