Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes #20

Merged
merged 1 commit into from
Apr 1, 2024
Merged

bug fixes #20

merged 1 commit into from
Apr 1, 2024

Conversation

ajkhattak
Copy link
Collaborator

@ajkhattak ajkhattak commented Feb 26, 2024

The PR resolves #19 and fixes two bugs related to missing non-optional parameters in the config file.

Additions

  • None

Removals

  • None

Changes

  • bug fixes
  • more descriptive screen outputs at the initialization step
  • typo (van Genuchten) corrected

Testing

  1. All existing tests passed

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Reviewers requested with the Reviewers tool ➡️

Copy link
Contributor

@peterlafollette peterlafollette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@peterlafollette peterlafollette merged commit 7d0d559 into master Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is soil_params_file an optional configuration option?
2 participants