-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying worker version #717
Merged
aaraney
merged 15 commits into
NOAA-OWP:master
from
robertbartel:f/specify_worker_image/main
Sep 10, 2024
Merged
Add support for specifying worker version #717
aaraney
merged 15 commits into
NOAA-OWP:master
from
robertbartel:f/specify_worker_image/main
Sep 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding worker_version to ExternalAbstractNgenRequest to be able to specify a requested version of a job worker.
Updating Launcher determine_image_for_job to use supplied worker_version value from originating request for ngen-type request objects, rather than always defaulting to "latest."
Move scheduler package internal dependency on communication to 0.22.0.
Updating client package internal dependency on communication to 0.22.0.
Updating requestservice internal dependency on communication to 0.22.0.
Updating schedulerservice dependencies on communication to 0.22.0 and scheduler to 0.14.0.
Instead of just external subclass.
aaraney
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow jobs to be requested using a version of the worker other than the default (i.e., the
latest
tag).Closes #662.
Changes
worker_version
, that defaults tolatest
if not explicitly setdetermine_image_for_job
function in Launcher class to use the newworker_version
attribute in nested job request object of ngen and ngen-cal jobs, rather than always justlatest
--worker-version
Testing
Checklist