[uwtools_integration] Integrate ics/lbcs

[WeirAE]

DESCRIPTION OF CHANGES:

A full integration of uwtools for the make_ics and make_lbcs tasks.

All fundamental tests have passed

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

TESTS CONDUCTED:

• hera.intel
• fundamental test suite

[WeirAE]

This will need to be updated with the changes from #268, but it is sufficiently complete otherwise for feedback

[NaureenBharwaniNOAA]

Here's my initial review. Will review more of it soon!

[maddenp-noaa]

I think there might be some changes coming, and will re-review after those. Maybe some changes suggested in this batch of comments will appear, too.

[maddenp-noaa]

Suggested change

	# pylint: disable=too-many-locals, too-many-statements, too-many-branches
	# pylint: disable-next=too-many-locals, too-many-statements, too-many-branches

I'm not sure this will work -- whether disable-next will apply to the next block and not just the next line, for those suppressors that relate to this function. If not, this line should probably move to the top of the module (after the #!) because, without -next, it applies to every line of code until the end of the module, and I think we should make this kind of interference with the linter more visibly obvious.

But some of this is also not bad advice from the linter: This function in 177 lines long. Could it be refactored into smaller, purpose-specific functions for better readability? I see what look like section comments describing various (maybe) unrelated operations, each of which could be its own function, which would then be somewhat self-documenting, e.g. we could change

# Extract driver config from experiment config

to function call

driver = get_driver(expt_config_cp)

and factor out the code to that function. If nothing else, there is a giant if / else block where the two alternatives might better be encapsulated in two functions.

[WeirAE]

I'm leaving this open for now to see what you think of the current shorter version. It might be a cleaner version as well if I moved the file linking or the loop off to a helper function?

[christinaholtNOAA]

Hi all, let's hold off on reviews for the moment. I'm going to push some changes. We'll let you know when it's ready for the next round of review.