Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed paths #38

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Conversation

kayeekayee
Copy link
Collaborator

Description

  1. Fix CCPP_SUITE to mynn.
  2. Fix all STMP and PTMP path to mynn.

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Ran sample run on Hera /scratch1/BMC/gsd-fv3-dev/KaYee.Wong/github/gsl_ufs_rt

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

    2) Fix all STMP and PTMP path to mynn.
Copy link

@jkhender jkhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMROT should be $GITDIR/FV3GFSrun
EXPDIR should be $GITDIR/FV3GFSwfm

when you run the Python scripts, then the directories $GITDIR/FV3GFSwfm/$PSLOT and $GITDIR/FV3GFSrun/$PSLOT will be created.

workflow/gsl_template_hera.xml Show resolved Hide resolved
workflow/gsl_template_jet.xml Show resolved Hide resolved
workflow/p8_ugwpv1.sh Outdated Show resolved Hide resolved
workflow/rocoto/workflow_xml_gsl.py Outdated Show resolved Hide resolved
workflow/rt_mynn_hera.sh Outdated Show resolved Hide resolved
workflow/rt_mynn_jet.sh Outdated Show resolved Hide resolved
workflow/test_hera.sh Outdated Show resolved Hide resolved
workflow/test_jet.sh Outdated Show resolved Hide resolved
Copy link

@jkhender jkhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jderrico-noaa jderrico-noaa merged commit b73f9d3 into NOAA-GSL:gsl_ufs_rt Feb 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants