-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using Decision Records #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error handling to the automation. If an ADR/SDR PR already existed and was still open, it would be silently overwritten by the next ADR/SDR
Also expand on the intended purpose and format.
ian-noaa
commented
Oct 11, 2024
ian-noaa
commented
Oct 11, 2024
docs/decisions/scientific/sdr-0002-we-will-recalculate-all-heights-for-raobs.md
Show resolved
Hide resolved
I think it is perfectly reasonable.
Randy Pierce
…On Thu, Oct 10, 2024 at 10:29 PM Ian McGinnis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
docs/decisions/scientific/sdr-0002-we-will-recalculate-all-heights-for-raobs.md
<#430 (comment)>:
> +### Positive
+
+- We will have consistent height levels for computing further verification statistics
+- The height levels will be derived from values we trust more than the recorded height; like temperature, pressure, and specific humidity.
+
+### Neutral
+
+- It is important to understand this interpolation technique when comparing our RAOB data to the data in the raw PrepBufr-formatted RAOB observation files. They do not compare one to one.
+
+### Negative
+
+- The height levels will be derived from other data, rather than using the measured values. This could differ from other ways the RAOB observation data is used in models.
+- We will be further interpolating the observations to the mandatory levels.
@mollybsmith-noaa <https://github.com/mollybsmith-noaa> & @randytpierce
<https://github.com/randytpierce> - I added a bit more to the Consequences
section here. Is this a fair description or should I revert my changes? I
want to make sure I'm not misrepresenting anything here.
—
Reply to this email directly, view it on GitHub
<#430 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGDVQPXIMEEIQ2CYCTAAYJLZ25HZVAVCNFSM6AAAAABPTD5NA2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRHEZTMNBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adopts decision records for this project. A distinction is made between "architectural" (decisions on software & infrastructure patterns & use) and "scientific" (decisions on how to calculate and handle data) records.
I've also added issue templates and automation so that we can create our ADR/SDR's in GitHub Issues, then add the "accepted" label and close them for them to be integrated into the repo.
Ideally, after this PR is merged, we will be able to have automation take care of ADR/SDR filenames and formatting.