better handle vegetation_type when vegetation_type is missing from grib file and also convert vegetation_type to string #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ib file and also convert vegetation_type to string
randytpierce
commented
Jan 29, 2024
ian-noaa
reviewed
Jan 30, 2024
There was a problem hiding this comment.
Generally looks okay. However, there was a comment that caused me some concern that I'd like to understand better. I'm hoping it's just leftover from development and can be deleted. 😄
I also had a comment about splitting one of our tests out so each test is more focused and gives us a better indication of what went wrong. It's up to you if you want to do that now Randy. I understand you want to get this merged soon.
ian-noaa
requested review from
gopa-noaa
and removed request for
JeffHamiltonNOAA
|
Adding Gopa as a reviewer - I believe that was Randy's original intent. |
|
ian-noaa
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered that I had not handled the case where a model didn't have any vegetation_type in the grib file, and i also realized that the handle_vegetation_type was not using the string value of veg_type in the json output. This PR corrects those oversights. I also adds a .prev and .tmp to the unit test for get_files.