Add a CI job to build our container images #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can now be done from the project board.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Couchbase needs to update their cbtools package before we can resolve the vulnerabilities Trivy has found.
Shift the cbtools from being included in the repo to being installed in the container. Update the import-docs.sh script to use the cbtools that exist on the PATH.
ian-noaa
force-pushed
the
build-container-in-ci
branch
from
964b687
to
6728c2d
Compare
randytpierce
approved these changes
Dec 21, 2023
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CI job to build the container images for
ingestandimport.Notable changes include:
amd64andx86_64)ingestimage - the eccodes layer was taking 23 of the 33 minutes to build. Note that it may make more sense to build theeccodeslayer as its own image instead of caching to avoid security issues.promqlandcbtools) and installedcbtoolsin the container imageimportimage to succeed. Couchbase needs to update theircbtoolsbinaries to resolve those vulnerabilities.