-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
221-investigate-replacing-pygrib-with-cfgribprobably-with-xarray-for-the-ingest-processes #230
Merged
randytpierce
merged 13 commits into
main
from
221-investigate-replacing-pygrib-with-cfgribprobably-with-xarray-for-the-ingest-processes
Sep 19, 2023
Merged
221-investigate-replacing-pygrib-with-cfgribprobably-with-xarray-for-the-ingest-processes #230
randytpierce
merged 13 commits into
main
from
221-investigate-replacing-pygrib-with-cfgribprobably-with-xarray-for-the-ingest-processes
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randytpierce
requested review from
gopa-noaa,
ian-noaa,
JeffHamiltonNOAA and
mollybsmith-noaa
August 17, 2023 21:28
…probably-with-xarray-for-the-ingest-processes
mollybsmith-noaa
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
ian-noaa
reviewed
Aug 30, 2023
ian-noaa
approved these changes
Sep 19, 2023
randytpierce
deleted the
221-investigate-replacing-pygrib-with-cfgribprobably-with-xarray-for-the-ingest-processes
branch
September 19, 2023 20:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement cfgrib and do some refactoring. Remove tests that are no longer in context. Prepare to be able to ingest Specific humidity and vegetation type. Add some more intense grib_to_cb tests and utliities for data inntegrity.