-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
232-ingest-process-monitoring-seems-to-be-not-working (#301)
This makes the scraper work with the new log file format. It also accounts for promql being an architecture specific binary that must be installed on the import platofrm (it is installed in the container image but not necessarily when running the import as a script). This exercise reinforces the need to migrate the metrics into the code somehow, although that won't be a trivial exercise.
- Loading branch information
Showing
6 changed files
with
374 additions
and
328 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ jobs: | |
- uses: actions/checkout@v4 | ||
- name: Install poetry | ||
run: pipx install poetry | ||
- uses: actions/setup-python@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.11" | ||
- name: Install dependencies | ||
|
@@ -38,7 +38,7 @@ jobs: | |
- uses: actions/checkout@v4 | ||
- name: Install poetry | ||
run: pipx install poetry | ||
- uses: actions/setup-python@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.11" | ||
- name: Install dependencies | ||
|
@@ -53,7 +53,6 @@ jobs: | |
- name: Code Coverage Report | ||
uses: irongut/[email protected] | ||
with: | ||
header: Test Coverage Report | ||
filename: coverage.xml | ||
badge: true | ||
fail_below_min: false | ||
|
@@ -78,7 +77,7 @@ jobs: | |
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Generate image metadata | ||
uses: docker/metadata-action@v4 | ||
uses: docker/metadata-action@v5 | ||
id: meta | ||
with: | ||
images: | | ||
|
@@ -124,7 +123,7 @@ jobs: | |
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Generate image metadata | ||
uses: docker/metadata-action@v4 | ||
uses: docker/metadata-action@v5 | ||
id: meta | ||
with: | ||
images: | | ||
|
@@ -160,6 +159,7 @@ jobs: | |
runs-on: ubuntu-latest | ||
needs: build-ingest | ||
steps: | ||
- uses: actions/checkout@v4 # Supply git info to upload-serif | ||
- name: Extract SHORT_SHA | ||
run: echo "SHORT_SHA=${GITHUB_SHA::7}" >> "$GITHUB_ENV" | ||
- name: Scan image with Trivy | ||
|
@@ -177,13 +177,14 @@ jobs: | |
TRIVY_PASSWORD: ${{ secrets.GITHUB_TOKEN }} | ||
- name: Upload Trivy scan results to GitHub Security tab | ||
if: always() | ||
uses: github/codeql-action/upload-sarif@v2 | ||
uses: github/codeql-action/upload-sarif@v3 | ||
with: | ||
sarif_file: "trivy-ingest-results.sarif" | ||
scan-import: | ||
runs-on: ubuntu-latest | ||
needs: build-import | ||
steps: | ||
- uses: actions/checkout@v4 # Supply git info to upload-serif | ||
- name: Extract SHORT_SHA | ||
run: echo "SHORT_SHA=${GITHUB_SHA::7}" >> "$GITHUB_ENV" | ||
- name: Scan image with Trivy | ||
|
@@ -201,6 +202,6 @@ jobs: | |
TRIVY_PASSWORD: ${{ secrets.GITHUB_TOKEN }} | ||
- name: Upload Trivy scan results to GitHub Security tab | ||
if: always() | ||
uses: github/codeql-action/upload-sarif@v2 | ||
uses: github/codeql-action/upload-sarif@v3 | ||
with: | ||
sarif_file: "trivy-import-results.sarif" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.