Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Nits #1144

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Fix CI Nits #1144

merged 11 commits into from
Jan 17, 2024

Conversation

ian-noaa
Copy link
Collaborator

@ian-noaa ian-noaa commented Jan 16, 2024

This PR does a bit of upkeep on our CI:

  • Builds the home app for git tags
  • Adds a job to clean up home app PR images
  • Adds the home app to the workflow that cleans up untagged container images
  • Adds the home app to the deploy job
  • Updates Dependabot to use development as the base branch instead of main for home app updates
  • Retires the add-issue-to-project.yml job - this is now built-in to the project board
  • Fixes a harmless but annoying failure where the PR container image cleanup workflow tried to cleanup non-existent MATS container images after a home app update
  • Adds CodeQL checks for our Go code
  • Standardizes home app/mats app CI workflow names

@ian-noaa ian-noaa self-assigned this Jan 16, 2024
@ian-noaa ian-noaa linked an issue Jan 16, 2024 that may be closed by this pull request
9 tasks
@ian-noaa ian-noaa changed the base branch from main to development January 16, 2024 20:32
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

GitHub Projects now has a feature to add new issues to boards
without needing a whole CI job.
Copy link
Collaborator

@mollybsmith-noaa mollybsmith-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but can you do the same for the METexpress repo so they stay equivalent? Thanks for handling this!

@ian-noaa
Copy link
Collaborator Author

Thanks for the review!

These changes were focused on accommodating the new home app. That app doesn't exist in the METexpress repo so there isn't much to do there - CI will continue to function normally.

@mollybsmith-noaa
Copy link
Collaborator

mollybsmith-noaa commented Jan 17, 2024 via email

@ian-noaa
Copy link
Collaborator Author

I double checked and it appears that GitHub projects can now interact with issues from across organization boundaries. I'll go ahead and remove the add-issue-to-project CI job in METexpress.

@ian-noaa ian-noaa merged commit 82479fe into development Jan 17, 2024
38 checks passed
@ian-noaa ian-noaa deleted the 1079-fix-ci-nits branch January 17, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI nits
2 participants