-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI Nits #1144
Fix CI Nits #1144
Conversation
This job is specific to changes to MATS apps. The home app should have a separate flow.
Additionally, increase the cut-off time to 1 week in case we want to review old images.
We don't want these to accumulate
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
GitHub Projects now has a feature to add new issues to boards without needing a whole CI job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but can you do the same for the METexpress repo so they stay equivalent? Thanks for handling this!
Thanks for the review! These changes were focused on accommodating the new home app. That app doesn't exist in the METexpress repo so there isn't much to do there - CI will continue to function normally. |
If there weren’t any non-home-app changes in addition then we should be
good. It’s just nice if they all match in terms of settings, timeouts, etc.
…On Wed, Jan 17, 2024 at 12:19 PM Ian McGinnis ***@***.***> wrote:
Thanks for the review!
These changes were focused on accommodating the new home app. That app
doesn't exist in the METexpress repo so there isn't much to do there - CI
will continue to function normally.
—
Reply to this email directly, view it on GitHub
<#1144 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHBWGZOVRCE6X2G52QYDS4LYPAP4XAVCNFSM6AAAAABB5NS34WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJWGQ4DAMBRGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
I double checked and it appears that GitHub projects can now interact with issues from across organization boundaries. I'll go ahead and remove the |
This PR does a bit of upkeep on our CI:
development
as the base branch instead ofmain
for home app updatesadd-issue-to-project.yml
job - this is now built-in to the project board