Linting the MATS apps #1117
Merged
Linting the MATS apps #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-noaa
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Generally looks good! I had three comments about:
- improving the format of those couchbase statements so that we didn't have to call
.replace()on them multiple times. - removing a now-unneeded comment in the
.eslintrc.jsonfile. - finding a way to reduce the number of
//eslint-diable-next-line no-undefcomments since the code seems to need a lot of them.
Since a lot of this is duplicate work, those comments apply to each of the apps.
|
I've addressed all your comments, so I'm going to merge this in the afternoon? |
|
Sounds good. Thanks! |
ian-noaa
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the linter errors in all the apps except upper air (ran out of time for that one). It also reorganizes a lot of the server-side code so that the selector values are addressed in the same order in all of the apps, which makes the code easier to take care of in the future.