Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official SchedMD debian RPMs to install Slurm #8

Merged
merged 16 commits into from
Jun 17, 2024

Conversation

christopherwharrop-noaa
Copy link
Collaborator

@christopherwharrop-noaa christopherwharrop-noaa commented Jun 13, 2024

This PR updates the version of Slurm from 19.0.5 to 23.11.7 by switching from the unofficial ubuntu RPMs to officially supported RPMs from SchedMD. SchedMD provides detailed instructions for building official Debian RPMs that allow very new versions of Slurm to be installed and allow easy upgrades of Slurm. The update was a major change, and thus required updates to config files to accommodate the newer version of Slurm. Closes #9

One consequence of this update is that ubuntu 22.04 is now required. This is because the RPM builds of Slurm do not work for Ubuntu 20.04.

Additionally, this update required a complete overhaul of the CI workflow because the builds now take a significant amount of time and emulation mode for ARM is no longer feasible. So, the workflow now uses native ARM runners to build multi-platform images that are pushed to ghcr.io instead of dockerhub.

Copy link
Collaborator

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments and questions.

.github/workflows/docker.yml Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be pushing a key to the repository?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, yes. There is no way to generate it dynamically and distribute it, and it's only used for internal communication between Slurm daemons.

frontend/docker-entrypoint.sh Show resolved Hide resolved
node/docker-entrypoint.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@christopherwharrop-noaa christopherwharrop-noaa merged commit 5e0ceee into main Jun 17, 2024
10 checks passed
@christopherwharrop-noaa christopherwharrop-noaa deleted the feature/upgrade-slurm branch June 17, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use officially supported RPMs
2 participants