Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add allocation checks to horiz_interp_type_eq #1584

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Sep 3, 2024

Description
Adds allocation checks for horiz_interp_type_eq before it assigns any allocatable fields.

Also adds some assignments to the test to reproduce the GNU errors from before these changes were made and cleans up some unused variables.

Fixes #1557

How Has This Been Tested?
gcc 13 and oneapi 2024.2 on the amd box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 marked this pull request as draft September 3, 2024 16:04
@rem1776 rem1776 marked this pull request as ready for review September 3, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

horiz_interp_type_eq does not work with gnu
1 participant