Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml_parser_mod: Use integral error code #1580

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

J-Lentz
Copy link
Contributor

@J-Lentz J-Lentz commented Aug 29, 2024

Description
PR #1563 introduced an error code which is returned by open_and_parse_file_wrap in yaml_parser_mod. This PR corrects the error code's type, which fixes a type mismatch error which occurs when building with the Cray compiler.

How Has This Been Tested?
Fixes the type mismatch error when building yaml_parser_mod with the Cray compiler.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

Use an integral value for the error code returned by `open_and_parse_file_wrap`
in `yaml_parser_mod`. This fixes a build error with the Cray compiler.
Copy link
Contributor

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this bug

@rem1776 rem1776 merged commit d85c442 into NOAA-GFDL:main Sep 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants