modern_diag: add the write_data calls #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-robinson
requested changes
Aug 9, 2023
| call buffer_obj(diag_file%buffer_ids(i))%write_buffer(fileobj) | ||
| enddo | ||
| else | ||
| do i = 1, diag_file%number_of_buffers |
There was a problem hiding this comment.
Can this be done in parallel?
There was a problem hiding this comment.
I don't think we can do io in parallel, yet(?)
There was a problem hiding this comment.
This is actually a great response lol
…update + minor documentation updates
|
@thomas-robinson I think everything is fixed in e6b86a4 |
rem1776
approved these changes
Aug 10, 2023
thomas-robinson
approved these changes
Aug 11, 2023
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* add the write_data calls * fix the test_flexible_time after the update
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
* add the write_data calls * fix the test_flexible_time after the update
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
rem1776
pushed a commit
to rem1776/FMS
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the write_data calls for the modern diag_manager.
There are separate subroutines for each of the fms2_io fileobjs because otherwise the write_data calls will go into the wrong interface
Fixes # (issue)
How Has This Been Tested?
CI
Checklist:
make distcheckpasses