Mixed precision astronomy #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcallic2
requested review from
rem1776,
thomas-robinson and
bensonr
as code owners
mlee03
reviewed
Aug 2, 2023
mlee03
suggested changes
Aug 2, 2023
mlee03
reviewed
Aug 2, 2023
mlee03
reviewed
Aug 14, 2023
mlee03
reviewed
Aug 16, 2023
fixes to astronomy
mlee03
approved these changes
Aug 18, 2023
rem1776
approved these changes
Aug 18, 2023
mlee03
reviewed
Aug 22, 2023
| real, dimension(size(lat),1) :: lat_2d, lon_2d, cosz_2d, & | ||
| fracday_2d, halfday_2d | ||
| t = (time - autumnal_eq_ref)//period_time_type | ||
| t = twopi*(t - real(t, r8_kind)) |
There was a problem hiding this comment.
@mcallic2 , was this originally a floor?
There was a problem hiding this comment.
I think it should have been real(floor(t),r8_kind)
rem1776
added a commit
that referenced
this pull request
Sep 20, 2023
BREAKING CHANGE: In coupler_types.F90, `coupler_nd_field_type` and `coupler_nd_values_type` have been renamed to indicate real kind value: `coupler_nd_real4/8_field_type` and `coupler_nd_real4/8_values_type`. The `bc` field within `coupler_nd_bc_type` was modified to use r8_kind within the value and field types, and an additional field added `bc_r4` to use r4_kind values. Includes: * feat: eliminate use of real numbers for mixed precision in `block_control` (#1195) * feat: mixed precision field_manager (#1205) * feat: mixed precision random_numbers_mod (#1191) * feat: mixed precision time_manager reals to r8 and clean up (#1196) * feat: mixed Precision tracer_manager (#1212) * Mixed precision monin_obukhov (#1116) * Mixed precision: `monin_obukhov` unit tests (#1272) * mixed-precision diag_integral_mod (#1217) * mixed precision time_interp (#1252) * mixed precision interpolator_mod (#1305) * Mixed precision astronomy (#1092) * Mixed precision `data_override_mod` (#1323) * mixed precision exchange (#1341) * coupler mixed precision (#1353) * Mixed precision topography_mod (#1250) --------- Co-authored-by: rem1776 <[email protected]> Co-authored-by: MiKyung Lee <[email protected]> Co-authored-by: mlee03 <[email protected]> Co-authored-by: Caitlyn McAllister <[email protected]> Co-authored-by: Jesse Lentz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to add mixed precision to astronomy files
Fixes # (issue)
How Has This Been Tested?
Autotools using oneapi and cmake
Checklist:
make distcheckpasses