Log exceptions and fix erroneous handling

[DavidHuber-NOAA]

Description

This fixes a few custom exceptions. Attempting to raise an exception object results in an unintended/misleading error. For instance,

try:
    1/0
except Exception as exc:
    raise exc("You can't divide by zero")

Results in

Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
ZeroDivisionError: division by zero

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 4, in <module>
TypeError: 'ZeroDivisionError' object is not callable

Instead, the base exception should be casted as a string:

try:
   1/0
except Exception as e:
   raise Exception(str(e) + "\nYou can't divide by zero")

Which returns

Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
ZeroDivisionError: division by zero

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 4, in <module>
Exception: division by zero
You can't divide by zero

In many cases, this is purely redundant as the message will already appear above. Thus, some exceptions were removed entirely or condensed.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• pynorms
• pytests

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing tests pass with my changes
• Any dependent changes have been merged and published

[codecov]

Codecov Report

Attention: Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (a7b49e9) to head (abe7fd4).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/wxflow/fsutils.py	25.00%	3 Missing ⚠️
src/wxflow/schema.py	0.00%	1 Missing ⚠️
src/wxflow/sqlitedb.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    52.41%   52.79%   +0.38%     
===========================================
  Files           18       18              
  Lines         1679     1680       +1     
  Branches       296      296              
===========================================
+ Hits           880      887       +7     
+ Misses         749      743       -6     
  Partials        50       50              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[WalterKolczynski-NOAA]

Why not just reraise the exception?

try:
   1/0
except Exception as exc:
   logger.exception("You can't divide by zero")
   raise exc

I dislike changing the exception type and inserting a possibly different one. The only reason we should be catching these in the first place is to write to the logger. Then just raise the same exception again if we aren't handling it.

[DavidHuber-NOAA]

Alright, I can work with that.

[DavidHuber-NOAA]

@WalterKolczynski-NOAA Alright, I added some logging and re-raising of caught exceptions.