Add taskid and run deterministic and EnKF DA cycles.

[hu5970]

Add taskid (jobid) to each task and run deterministic and EnKF DA cycles.

Tests:

• WCOSS2
  • [x ] Cactus/Dogwood
• RRFS_A:

[BenjaminBlake-NOAA]

@hu5970 Thanks for submitting this PR! I was planning to work on this soon. My initial PR was just for the non-DA tasks. I think some of the other J-jobs will need to be modified too, like JRRFS_ANALYSIS_GSI for example. Should those modifications also be included in this PR?

[MatthewPyle-NOAA]

One question about taskid/jobid - pretty sure Ben and I have discussed that previously, but not remembering the details.

[MatthewPyle-NOAA]

Question for you and @BenjaminBlake-NOAA

Since jobid is intended to be passed in from the "job card" - ecflow job in production, should we define it more like this?

export jobid=${jobid:-${taskid}}

[BenjaminBlake-NOAA]

@MatthewPyle-NOAA I agree that definition of $jobid is probably best, since we will replace $taskid with $job.$PBS_JOBID eventually.

[hu5970]

I added some of the jobid to the master branch for testing RRFS_A DA cycles. The system can run through for now but I certainly missed some JOBID. Could we merge this PR and then Ben can work on adding more JobID to other tasks?

[MatthewPyle-NOAA]

@hu5970 That works for me. I opened an issue about it (#525) as a reminder.

[MatthewPyle-NOAA]

Approving since this system runs, but with an issue (#525) about more uniformly applying a way to handle $jobid with rocoto-driven workflows, while also working well for ecflow-driven workflows.

[BenjaminBlake-NOAA]

@hu5970 @MatthewPyle-NOAA Yes that sounds good to me. I will submit a PR for this early next week.

[guoqing-noaa]

Do we expect taskid here to be jobid, right?

[BenjaminBlake-NOAA]

Yes it should be $jobid. I can plan to fix that with my upcoming PR where jobid=${jobid:-taskid}