Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port obs-monitor to wcoss2 #34

Merged
merged 14 commits into from
Jun 26, 2024
Merged

Port obs-monitor to wcoss2 #34

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9f9634d
Ref #32
EdwardSafford-NOAA May 9, 2024
982f3c4
ref #32
EdwardSafford-NOAA Jun 5, 2024
64ec897
Ref #32
EdwardSafford-NOAA Jun 24, 2024
95e8521
Ref #32
EdwardSafford-NOAA Jun 24, 2024
2726724
Ref #32
EdwardSafford-NOAA Jun 24, 2024
45c125e
Ref #32
EdwardSafford-NOAA Jun 24, 2024
196737e
Ref #32
EdwardSafford-NOAA Jun 24, 2024
3ed9480
Ref #32
EdwardSafford-NOAA Jun 24, 2024
6b52b37
Ref #22
EdwardSafford-NOAA Jun 24, 2024
9853799
Merge branch 'develop' into feature/wcoss2-32
EdwardSafford-NOAA Jun 25, 2024
95d7c5c
Ref #32
EdwardSafford-NOAA Jun 25, 2024
4e8351d
Merge branch 'feature/wcoss2-32' of https://github.com/EdwardSafford-…
EdwardSafford-NOAA Jun 25, 2024
d18e15b
Ref #32
EdwardSafford-NOAA Jun 26, 2024
d82f9d3
Ref #32
EdwardSafford-NOAA Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions driver/runObsMon.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,13 +86,13 @@ export COMOUT=${COMOUT}/${NET}
#-------------------------
# Set up & submit j-job
#
jobname="PlotObsMon"
jobname="PlotObsMon_setup"
jobfile="${JOBSobsmon}/JMON_PLOT_OBS"

logdir="${OM_LOGS}/${MODEL}"
if [[ ! -d ${logdir} ]]; then mkdir -p ${logdir}; fi

logfile="${OM_LOGS}/${MODEL}/OM_log"
logfile="${logdir}/OM_setup.log"
if [[ -e ${logfile} ]]; then rm ${logfile}; fi

case ${MACHINE_ID} in
Expand All @@ -101,9 +101,13 @@ case ${MACHINE_ID} in
-J ${jobname} --partition service -o ${logfile} ${jobfile}
;;

wcoss2) # NOTE: this has not been tested; eva doesn't yet run on wcoss2
$SUB -q $JOB_QUEUE -A $ACCOUNT -o ${logfile} -e ${logfile} \
-V -l select=1:mem=500M -l walltime=0:05:00 -N ${jobname} ${jobfile}
wcoss2)
$SUB -q ${JOB_QUEUE} -A ${ACCOUNT} -o ${logfile} -e ${logfile} \
-v "PYTHONPATH=${PYTHONPATH}, PATH=${PATH}, HOMEobsmon=${HOMEobsmon}, COMOUT=${COMOUT}, \
MODEL=${MODEL}, PDY=${PDY}, cyc=${cyc}, DATAROOT=${DATAROOT}, APRUN_PY=${APRUN_PY}, \
MACHINE_ID=${MACHINE_ID}, ACCOUNT=${ACCOUNT}, JOB_QUEUE=${JOB_QUEUE}, SUB=${SUB},
OM_LOGS=${OM_LOGS}" \
-l select=1:mem=500mb -l walltime=0:05:00 -N ${jobname} ${jobfile}
;;
esac

Expand Down
2 changes: 0 additions & 2 deletions jobs/JMON_PLOT_OBS
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,3 @@ fi
KEEPDATA=${KEEPDATA:-"NO"}
cd ${DATAROOT}
[[ ${KEEPDATA} = "NO" ]] && rm -rf ${DATA}

report-mem
4 changes: 2 additions & 2 deletions parm/OM_config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export JOBSobsmon=${om_dir_root}/jobs
# Export job submission vars per MACHINE_ID
#
source ${om_dir_root}/ush/detect_machine.sh
MACHINE_ID=`echo "${MACHINE_ID%%.*}"`
export MACHINE_ID=`echo "${MACHINE_ID%%.*}"`

case ${MACHINE_ID} in

Expand All @@ -31,7 +31,7 @@ case ${MACHINE_ID} in
queue="dev"
project="GDAS-DEV"
account="GFS-DEV"
aprun_py="python"
aprun_py=`which python`
;;
esac

Expand Down
20 changes: 10 additions & 10 deletions parm/gfs/conTime.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,13 +460,13 @@ graphics:
figure:
layout: [4,1]
figure size: [20,18]
tight layout:
# tight layout:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevindougherty-noaa can we figure out why tight layout and plot logo aren't working on wcoss?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwardSafford-NOAA What is the error that occurs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traceback (most recent call last):
File "/lfs/h2/emc/da/noscrub/edward.safford/eva/opt/bin/eva", line 8, in
sys.exit(main())
File "/lfs/h2/emc/da/noscrub/edward.safford/eva/opt/eva/eva_driver.py", line 120, in main
eva(config_file)
File "/lfs/h2/emc/da/noscrub/edward.safford/eva/opt/eva/eva_driver.py", line 85, in eva
figure_driver(eva_dict, data_collections, timing, logger)
File "/lfs/h2/emc/da/noscrub/edward.safford/eva/opt/eva/plotting/batch/base/plot_tools/figure_driver.py", line 150, in figure_driver
make_figure(handler, figure_conf, plots_conf,
File "/lfs/h2/emc/da/noscrub/edward.safford/eva/opt/eva/plotting/batch/base/plot_tools/figure_driver.py", line 256, in make_figure
fig.save_figure(output_file, **saveargs)
File "/lfs/h2/emc/da/noscrub/edward.safford/eva/opt/emcpy/plots/create_plots.py", line 232, in save_figure
self.fig.savefig(pathfile, **kwargs)
File "/apps/prod/ve/intel/19.1.3.304/python/3.10.4/evs/1.0/lib/python3.10/site-packages/matplotlib/figure.py", line 3343, in savefig
self.canvas.print_figure(fname, **kwargs)
File "/apps/prod/ve/intel/19.1.3.304/python/3.10.4/evs/1.0/lib/python3.10/site-packages/matplotlib/backend_bases.py", line 2366, in print_figure
result = print_method(
File "/apps/prod/ve/intel/19.1.3.304/python/3.10.4/evs/1.0/lib/python3.10/site-packages/matplotlib/backend_bases.py", line 2232, in
print_method = functools.wraps(meth)(lambda *args, **kwargs: meth(
TypeError: FigureCanvasAgg.print_png() got an unexpected keyword argument 'tight layout'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same issue is at play with the logos, it reports an unexpected keyword argument.

title: "Valid: {{ PDATE | to_YMDH }} \n ${datatype}, Global, All Levels"
output name: line_plots/con/time/${datatype}_count.{{ PDATE | to_YMDH }}.png
plot logo:
which: 'noaa/nws'
loc: 'upper left'
subplot_orientation: 'last'
# plot logo:
# which: 'noaa/nws'
# loc: 'upper left'
# subplot_orientation: 'last'

plots:
- add_xlabel: 'Assimilated'
Expand Down Expand Up @@ -584,13 +584,13 @@ graphics:
figure:
layout: [6,1]
figure size: [20,18]
tight layout:
# tight layout:
title: "Valid: {{ PDATE | to_YMDH }}\n ${datatype}, Global, All Levels"
output name: line_plots/con/time/${datatype}_bias.{{ PDATE | to_YMDH }}.png
plot logo:
which: 'noaa/nws'
loc: 'upper left'
subplot_orientation: 'last'
# plot logo:
# which: 'noaa/nws'
# loc: 'upper left'
# subplot_orientation: 'last'

plots:
- add_xlabel: 'Obs-Ges Assimilated'
Expand Down
10 changes: 5 additions & 5 deletions parm/gfs/conVert.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ graphics:
figure:
layout: [2,2]
figure size: [20,18]
tight layout:
# tight layout:
title: "Valid: {{ PDATE | to_YMDH }} \n ${datatype}, Global"
output name: line_plots/con/vert/${datatype}.vert.png
plot logo:
which: 'noaa/nws'
loc: 'upper left'
subplot_orientation: 'first'
# plot logo:
# which: 'noaa/nws'
# loc: 'upper left'
# subplot_orientation: 'first'

plots:
- add_xlabel: 'Assimilated'
Expand Down
4 changes: 2 additions & 2 deletions parm/gfs/gfs_plots.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ satellites:
times: 121
channels: 'all'
component: ges
# file corruption here?
# test data file corruption here?
# - plot: rad angle
# times: 121
# channels: 'all'
Expand Down Expand Up @@ -321,7 +321,7 @@ satellites:
channels: 'all'
component: ges

# file corruption?
# test data file corruption here
# - name: n19
# instruments:
# - name: amsua
Expand Down
Loading
Loading