Turn C96C48_ufs_hybatmDA and C48mx500_3DVarAOWCDA into a regression test #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidNew-NOAA
requested review from
aerorahul,
RussTreadon-NOAA and
CoryMartin-NOAA
13 tasks
|
@CoryMartin-NOAA Done! |
|
I misunderstood how default yamls work. I'm merging Cory's branch into mine and redoing the test references |
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Nov 25, 2024
This PR is a companion to GW PR [#3120](NOAA-EMC/global-workflow#3120). It does a couple things: 1. 5 GW CI tests are added/extended as CTests in GDASApp, running through to the fcst jobs in the first full-cycle. These CI tests are: ```C96C48_hybatmDA```, ```C96C48_ufs_hybatmDA```, ```C96C48_hybatmaerosnowDA```, ```C48mx500_3DVarAOWCDA```, and ```C48mx500_hybAOWCDA```. 2. Test references are added for ```C96C48_ufs_hybatmDA``` and ```C48mx500_3DVarAOWCDA```, so that we're actually testing the output. 3. These CTests are turned on by default in a workflow build, rather than having to mess with the ```CMakeCache.txt``` file and re-running make. This will allow us to use these tests in nightly testing. 4. ```test/gw-ci/CMakeLists.txt``` is refactored quite a bit. 5. There are 89 CTests, but for 5 CI tests, but I added task dependencies, so they can be run in parallel. The primary motivation for this PR is that we can run CI for our nightly testing of GDASApp. Also, anyone with a PR can easily do CI testing through CTests. --------- Co-authored-by: Russ-Treadon-NOAA <[email protected]>
TerrenceMcGuinness-NOAA
added
the
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
Checkout Failed on Hera in Build# 2: Could not perform submodule update |
1 similar comment
|
Checkout Failed on Hera in Build# 2: Could not perform submodule update |
emcbot
added
CI-Hera-Failed
TerrenceMcGuinness-NOAA
added
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
Build FAILED on Hera in Build# 3 with error logs: Follow link here to view the contents of the above file(s): (link) |
|
Build FAILED on Hera in Build# 3 with error logs: Follow link here to view the contents of the above file(s): (link) |
emcbot
added
CI-Hera-Failed
Build failed due to fork resource unavailable |
4 tasks
|
WCOSS2 g-w CI Install All streams successfully ran to completion except except C48mx500_3DVarAOWCDA and C48mx500_hybAOWCDA. These streams are stuck because required GDA files for 20210325 00Z do not exist on Dogwood. g-w issue #3159 has been opened requesting that the GDA directory for 20210325 00Z be copied from Hera to WCOSS2. |
|
Orion g-w CI Install All streams successfully ran to completion. |
|
Hera g-w CI Install All streams successfully ran to completion. |
RussTreadon-NOAA
approved these changes
Dec 12, 2024
|
Thanks for the manual testing @RussTreadon-NOAA |
|
@WalterKolczynski-NOAA , @aerorahul and @KateFriedman-NOAA : g-w CI testing has been completed on WCOSS2 (Dogwood), Hera, and Orion. All tested streams successfully ran to completion with the following caveats
Both C48mx500_3DVarAOWCDA and C48mx500_hybAOWCDA are set to be skipped on WCOSS2. I run AOWCDA on WCOSS2 because GFS v17 will exercise AOWCDA. Is the amount of g-w CI tested reported in this issue sufficient for this PR to be approved and merged into develop? If not, what else must done? |
RussTreadon-NOAA
added
CI-Hera-Passed
WalterKolczynski-NOAA
merged commit 0c7a3c6
into
NOAA-EMC:develop
9 of 11 checks passed
|
Thank you @WalterKolczynski-NOAA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a companion to GDASApp PR #1365 (merged).
It turns
C96C48_ufs_hybatmDAandC48mx500_3DVarAOWCDAinto a regression test using the JEDI application testing feature. This feature is turned on using the newDO_TEST_MODEparameter added toconfig.basein GW PR #3115. This parameter is set to"YES"in the yaml defaults for the JEDI-based CI tests in GW.The motivation for this PR is a need to catch changes in JEDI which alter the outputs of our applications.
Type of change
Change characteristics
How has this been tested?
C96C48_hybatmDA,C96C48_ufs_hybatmDA,C96C48_hybatmaerosnowDA,C48mx500_3DVarAOWCDA, andC48mx500_hybAOWCDAhave been tested successfully on HeraChecklist