Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doxygen updates to module_write_internal_state.F90 and io/module_write_netcdf.F90 #762

Merged
merged 10 commits into from
Jan 25, 2024

Conversation

edwardhartnett
Copy link
Collaborator

Description

doxygen updates to io/module_write_netcdf.F90m and module_write_netcdf.F90.

We need some information filled in by @DusanJovic-NOAA and @junwang-noaa (look for "???" and replace it with documentation).

Issue(s) addressed

Part of #760

Testing

Only documentation changes in this PR.

Dependencies

N/A

@edwardhartnett edwardhartnett marked this pull request as ready for review January 17, 2024 12:20
@edwardhartnett
Copy link
Collaborator Author

Thanks @DusanJovic-NOAA !

This PR is ready to review and merge.

@DusanJovic-NOAA DusanJovic-NOAA changed the title doxygen updates to io/module_write_netcdf.F90m and module_write_netcdf.F90 doxygen updates to io/module_write_netcdf.F90 and io/module_write_netcdf.F90 Jan 18, 2024
@junwang-noaa junwang-noaa changed the title doxygen updates to io/module_write_netcdf.F90 and io/module_write_netcdf.F90 doxygen updates to module_write_internal_state.F90 and io/module_write_netcdf.F90 Jan 19, 2024
@edwardhartnett
Copy link
Collaborator Author

This PR is ready to merge...

@junwang-noaa
Copy link
Collaborator

@DusanJovic-NOAA would you please test this PR in UFS before committing it? Thanks

@DusanJovic-NOAA
Copy link
Collaborator

@edwardhartnett Please sync this branch with develop.

@edwardhartnett
Copy link
Collaborator Author

@DusanJovic-NOAA I have synced.

@DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA I have synced.

This branch (ejh_d5) is still one commit behind.

@edwardhartnett
Copy link
Collaborator Author

@DusanJovic-NOAA sorry, wrong branch! I've updated ejh_d5 now and we should be good to go...

@DusanJovic-NOAA
Copy link
Collaborator

Test passed on Hera. RegressionTests_hera.log

Ready to merge.

@DusanJovic-NOAA DusanJovic-NOAA merged commit a2c9176 into NOAA-EMC:develop Jan 25, 2024
2 checks passed
@edwardhartnett edwardhartnett deleted the ejh_d5 branch January 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants