Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grv function used by NST #722

Merged
merged 8 commits into from
Nov 20, 2023

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Nov 15, 2023

Description

Changes argument used by grv function.

Issue(s) addressed

Testing

Dependencies

@DusanJovic-NOAA
Copy link
Collaborator

Can this PR be combined with #719?

@DeniseWorthen
Copy link
Collaborator Author

@DusanJovic-NOAA Since this changes so many baselines, I'd prefer to have it go alone. The other PR is not breaking anything but I want to make a few more changes.

@DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA Since this changes so many baselines, I'd prefer to have it go alone. The other PR is not breaking anything but I want to make a few more changes.

OK. Thanks. I should have looked at corresponding UFSWM PRs to see that one PR changes baselines and other doesn't.

@zach1221
Copy link
Collaborator

@jkbk2004 we have approval here and are ready to merge.

@jkbk2004 jkbk2004 merged commit cd2c3b7 into NOAA-EMC:develop Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grv function used by NST assumes wrong argument
5 participants